Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlDatabase: Enable snapshot isolation #845

Open
bozho opened this issue Sep 25, 2017 · 4 comments · May be fixed by #1622
Open

SqlDatabase: Enable snapshot isolation #845

bozho opened this issue Sep 25, 2017 · 4 comments · May be fixed by #1622
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@bozho
Copy link
Contributor

bozho commented Sep 25, 2017

Hi,

Would there be interest for improving/expanding xSQLServerDatabase, xSQLServerDatabasePermission and xSQLServerDatabaseRole resources?

We currently have a need for the following functionality, which we've covered with custom resources:

Enabling/disabling snapshot isolation (and perhaps other DB properties) could be added to the xSQLServerDatabase resource.

xSQLServerDatabaseRole is a bit confusing, since it doesn't create/delete roles. Instead, it will create a DB user for a login and assign it an existing role. I think it would be better to have a resource for managing DB roles and a separate resource for user mapping and (maybe) role membership.

xSQLServerDatabasePermission will also add a DB user if it doesn't exist and assign permissions to it. Again, I think we would benefit here from having a separate resource for DB user management and use xSQLServerDatabasePermission to manage permissions on both users and roles.

I'm more than happy to start working on this, but I'd like to hear others' thoughts and ideas.

@johlju
Copy link
Member

johlju commented Sep 25, 2017

Could you please split this issue into at least one per resource? It will be easier to comment then. Thanks. 😄

@bozho
Copy link
Contributor Author

bozho commented Sep 25, 2017

Done: issues #846, #847 and #848

@johlju
Copy link
Member

johlju commented Sep 26, 2017

Are we tracking the snapshot isolation on a database in this issue? Could you please change the title and issue description on this issue to reflect that?

I'm all for adding this functionality. Could you please propose a schema.mof with the changes needed for handle the isolation?

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Sep 26, 2017
@johlju johlju changed the title xSQLServerDatabase, xSQLServerDatabasePermission and xSQLServerDatabaseRole improvements SqlDatabase, SqlDatabasePermission and SqlDatabaseRole improvements Dec 23, 2017
@johlju johlju changed the title SqlDatabase, SqlDatabasePermission and SqlDatabaseRole improvements SqlDatabase: Enable snapshot isolation May 30, 2019
@johlju
Copy link
Member

johlju commented May 30, 2019

I updated the title and issue description is this issue so we know what we are tracking with this issue. Please correct me if I'm wrong.

johlju pushed a commit that referenced this issue Jun 4, 2019
…ng roles, managing membership (#1367)

- Changes to SqlDatabaseRole
  - BREAKING CHANGE: Refactored to enable creation/deletion of the database role
    itself as well as management of the role members. *Note that the resource no
    longer adds database users.* (issue #845, issue #847, issue #1252, issue #1339).
@awickham10 awickham10 linked a pull request Oct 3, 2020 that will close this issue
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants