-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlDatabase: Enable snapshot isolation #845
Comments
Could you please split this issue into at least one per resource? It will be easier to comment then. Thanks. 😄 |
Are we tracking the snapshot isolation on a database in this issue? Could you please change the title and issue description on this issue to reflect that? I'm all for adding this functionality. Could you please propose a schema.mof with the changes needed for handle the isolation? |
I updated the title and issue description is this issue so we know what we are tracking with this issue. Please correct me if I'm wrong. |
…ng roles, managing membership (#1367) - Changes to SqlDatabaseRole - BREAKING CHANGE: Refactored to enable creation/deletion of the database role itself as well as management of the role members. *Note that the resource no longer adds database users.* (issue #845, issue #847, issue #1252, issue #1339).
Hi,
Would there be interest for improving/expanding xSQLServerDatabase, xSQLServerDatabasePermission and xSQLServerDatabaseRole resources?
We currently have a need for the following functionality, which we've covered with custom resources:
create roles on a DBRelated moved to issue SqlDatabaseUser: New resource #846 and BREAKING CHANGE: SqlDatabaseRole: Should only handle database roles and not create database users #847assign permissions to rolesRelated moved to issue BREAKING CHANGE: SqlDatabasePermission: Remove database user creation, and add assigning permission to roles #848Enabling/disabling snapshot isolation (and perhaps other DB properties) could be added to the xSQLServerDatabase resource.
xSQLServerDatabaseRole is a bit confusing, since it doesn't create/delete roles. Instead, it will create a DB user for a login and assign it an existing role. I think it would be better to have a resource for managing DB roles and a separate resource for user mapping and (maybe) role membership.xSQLServerDatabasePermission will also add a DB user if it doesn't exist and assign permissions to it. Again, I think we would benefit here from having a separate resource for DB user management and use xSQLServerDatabasePermission to manage permissions on both users and roles.I'm more than happy to start working on this, but I'd like to hear others' thoughts and ideas.
The text was updated successfully, but these errors were encountered: