Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlDatabaseRole: Should only handle database roles and not create database users #847

Closed
bozho opened this issue Sep 25, 2017 · 2 comments · Fixed by #1367
Closed

BREAKING CHANGE: SqlDatabaseRole: Should only handle database roles and not create database users #847

bozho opened this issue Sep 25, 2017 · 2 comments · Fixed by #1367
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@bozho
Copy link
Contributor

bozho commented Sep 25, 2017 •
edited
Loading

xSQLServerDatabaseRole resource currently creates a DB user for an SQL login and assigns already existing roles to the user.

The related issue (#846) proposes renaming the resource to xSQLServerDatabaseUser.

We should then implement a new resource xSQLServerDatabaseRole, used to handle DB roles.
@bozho bozho mentioned this issue Sep 25, 2017
Open
@johlju johlju mentioned this issue Sep 26, 2017
Closed
@johlju johlju changed the title [Resource proposal] xSQLServerDatabaseRole xSQLServerDatabaseRole: should only handle database roles and not create database users Sep 26, 2017
@johlju johlju changed the title xSQLServerDatabaseRole: should only handle database roles and not create database users xSQLServerDatabaseRole: Should only handle database roles and not create database users Sep 26, 2017
@johlju
Copy link
Member

johlju commented Sep 26, 2017

I changed the title on this issue to better reflect the change that should be done. Correct me if I'm wrong.
Also see issue #846.

I suggest we change this resource to use the same/similar schema.mof as xSQLServerRole.

@johlju johlju changed the title xSQLServerDatabaseRole: Should only handle database roles and not create database users BREAKING CHANGE: xSQLServerDatabaseRole: Should only handle database roles and not create database users Sep 26, 2017
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Sep 26, 2017
@johlju
Copy link
Member

johlju commented Sep 26, 2017

@bozho Could you propose a schema.mof for this as well?

@johlju johlju changed the title BREAKING CHANGE: xSQLServerDatabaseRole: Should only handle database roles and not create database users BREAKING CHANGE: SqlDatabaseRole: Should only handle database roles and not create database users Dec 23, 2017
This was referenced May 24, 2019
Closed
Merged
johlju pushed a commit that referenced this issue Jun 4, 2019
@pshamus @johlju
BREAKING CHANGE: SqlDatabaseRole: Refactored to support adding/removi…
b2c5778 
…ng roles, managing membership (#1367)

- Changes to SqlDatabaseRole
  - BREAKING CHANGE: Refactored to enable creation/deletion of the database role
    itself as well as management of the role members. *Note that the resource no
    longer adds database users.* (issue #845, issue #847, issue #1252, issue #1339).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
2 participants
@bozho @johlju