SqlServerMemory: Fix so auto memory on Azure VMs is reported correctly #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) - Changes to SqlServiceAccount - Fixed Get-ServiceObject when searching for Integration Services service. Unlike the rest of SQL Server services, the Integration Services service cannot be instanced, however you can have multiple versions installed. Get-Service object would return the correct service name that you are looking for, but it appends the version number at the end. Added parameter VersionNumber so the search would return the correct service name. - Added code to allow for using Managed Service Accounts. - Changes to SqlServerLogin - Fixed issue in Test-TargetResource to valid password on disabled accounts (issue #915).
- Changes to SqlServerDsc - Reverting the change that was made as part of the issue #1260 in the previous release, as it only mitigated the issue, it did not solve the issue. - Removed the container testing since that broke the integration tests, possible due to using excessive amount of memory on the AppVeyor build worker. This will make the unit tests to take a bit longer to run (issue #1260). - The unit tests and the integration tests are now run in two separate build workers in AppVeyor. One build worker runs the integration tests, while a second build worker runs the unit tests. The build workers runs in parallel on paid accounts, but sequentially on free accounts (issue #1260). - Clean up error handling in some of the integration tests that was part of a workaround for a bug in Pester. The bug is resolved, and the error handling is not again built into Pester. - Changes to SqlSetup - Updated the integration test to stop the named instance while installing the other instances to mitigate issue #1260.
- Changes to SqlServerEndpoint - Add the optional parameter Owner. The default owner remains the login used for the creation of the endpoint (issue #1251).
- Fix minor typos in CHANGELOG.md
- Changes to SqlSetup
- Add parameters to configure the Tempdb files during the installation of the instance.
The new parameters are SqlTempdbFileCount, SqlTempdbFileSize, SqlTempdbFileGrowth,
SqlTempdbLogFileSize and SqlTempdbLogFileGrowth (issue #1167).
- Speeding up the AppVeyor tests by splitting the common tests in a separate build job.
…1255) - Added SqlAgentOperator Resource.
- Changes to SqlServerEndpoint - Add integration tests (issue #744).
- Changes to SqlServerDsc
- Updated the appveyor.yml to have the correct build step, and also
correct run the build step only in one of the jobs.
- Changes to SqlServerDsc
- Update integration tests to use the new integration test template.
- Changes to SqlServiceAccount
- Now the correct service type string value is returned by the function
`Get-TargetResource`. Previously one value was passed in as a parameter
(e.g. `DatabaseEngine`), but a different string value as returned
(e.g. `SqlServer`). Now `Get-TargetResource` return the same values
that can be passed as values in the parameter `ServiceType` (issue #981).
|
Closing this PR as it is targeting the master branch, and there is another correct PR sent in after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Cim Class to Win32_ComputerSystem (instead of Win32_PhysicalMemory) because the correct memory size was not being detected correctly on Azure VMs
Fixes #914
Fixes #1154
This change is