SqlRole: Fix default for ServerName

[cmcapellan]

Pull Request (PR) description

Fixed:

• The ServerName paramer is optional and defaults to $env:COMPUTERNAME, but Test-TargetResource uses the $PSBoundParameters automatic variable which ignores default values for parameters. Looks like this was fixed by BREAKING CHANGE: SqlServerDsc: Make parameter ServerName non-mandatory #1503 in several other places such as SqlDatabasePermission but was missed here.

This Pull Request (PR) fixes the following issues

• Fixes SqlRole resource incorrect documentation or bug #1592

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1597 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1597   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6082    6082           
======================================
  Hits         5978    5978           
  Misses        104     104           

Flag	Coverage Δ
#unit	98% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
source/DSCResources/DSC_SqlRole/DSC_SqlRole.psm1	99% <100%> (ø)

[johlju]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

@cmcapellan thank you for fixing this! I will release a patch version tomorrow.

[cmcapellan]

@johlju thanks for approving my PR! Looking forward to your release as I need this for a project I'm working on...

[johlju]

Pushed a full release now, if the test passes it will be deployed within 3 hours. There have recently been some intermittent issues when running integration tests which makes me need to re-run them manually. :/

[cmcapellan]

Great, thanks again! Now working on how to pass two variables with SqlScriptQuery, unfortunately the examples are all for one variable. If I figure out may submit a PR for the example...

[johlju]

It uses Invoke-Sqlcmd behind the scenes so examples or the documentation for that cmdlet might help you. Happily review a PR for an example for that 🙂

[cmcapellan]

Hi @johlju I see v14.2.0-preview0005 is released and there is alos 14.2 tag, are you going to release 14.2 in the next few hours?

[cmcapellan]

@johlju I see it now 😀 Thanks!