Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlRole: Fix default for ServerName #1597

Merged
merged 3 commits into from
Jul 22, 2020
Merged

SqlRole: Fix default for ServerName #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c186cca
Fix default for $ServerName in SqlRole
cmcapellan Jul 22, 2020
9ee353e
Update for PR#1597
cmcapellan Jul 22, 2020
2bf3d09
Update CHANGELOG.md
johlju Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
_Restrict clients allowed to make remote calls to SAM_ can result in
a access denied error during install of the _SQL Server Database Engine_
([issue #1559](https://github.com/dsccommunity/SqlServerDsc/issues/1559)).
- SqlRole
- Fixed the `ServerName` parameter to work with default value of
`$env:COMPUTERNAME` ([issue #1592](https://github.com/dsccommunity/SqlServerDsc/issues/1592)).

## [14.1.0] - 2020-07-06

Expand Down
2 changes: 1 addition & 1 deletion source/DSCResources/DSC_SqlRole/DSC_SqlRole.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ function Test-TargetResource

$getTargetResourceParameters = @{
InstanceName = $PSBoundParameters.InstanceName
ServerName = $PSBoundParameters.ServerName
ServerName = $ServerName
ServerRoleName = $PSBoundParameters.ServerRoleName
Members = $PSBoundParameters.Members
MembersToInclude = $PSBoundParameters.MembersToInclude
Expand Down