Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlLogin: Update/Fix to CHANGELOG.md comments relating to PR #1652 #1670

Merged
merged 12 commits into from
Jan 12, 2021

Conversation

SphenicPaul
Copy link
Contributor

@SphenicPaul SphenicPaul commented Jan 12, 2021

Pull Request (PR) description

Update to CHANGELOG.md to correct the change/PR (#1652) made around PasswordExpirationEnabled and PasswordPolicyEnforced properties/parameters. This change was previously described as a sequencing/order change, but the final change implemented was one that updates both properties together.

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 17c7d49 into dsccommunity:main Jan 12, 2021
@johlju
Copy link
Member

johlju commented Jan 12, 2021

@SphenicPaul thank you! 🙂

@SphenicPaul SphenicPaul deleted the pjw-issue361-ChangeLogPostFix branch January 13, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants