Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database to load 7 new MODE CTS statistics #226

Closed
7 of 21 tasks
JohnHalleyGotway opened this issue Aug 18, 2023 · 3 comments
Closed
7 of 21 tasks

Update database to load 7 new MODE CTS statistics #226

JohnHalleyGotway opened this issue Aug 18, 2023 · 3 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading component: METdataio priority: high High Priority requestor: NOAA/CPC NOAA Climate Prediction Center type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Aug 18, 2023

Describe the Enhancement

MET issue dtcenter/MET#2648 and corresponding pull request dtcenter/MET#2655 adds 7 new columns of output to the end of the MODE CTS line type:
LODDS, ORSS, EDS, SEDS, EDI, SEDI, BAGSS

This issue is to update METdataio to load this new data. Include instructions in the Release Notes and provide an update_for_v_x_release_cycle.sql in the METdataio/METdbLoad/sql/udates directory

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues

Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version

  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading priority: high High Priority requestor: NOAA/CPC NOAA Climate Prediction Center component: METdataio labels Aug 18, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the METdataio-3.0.0 milestone Aug 18, 2023
@hankenstein2 hankenstein2 self-assigned this Feb 28, 2024
@hankenstein2
Copy link
Contributor

Possibly done, find original pull request to link

@bikegeek
Copy link
Collaborator

bikegeek commented May 15, 2024

Looking at the METdbLoad/ush/constants.py, these 7 columns are included, so data containing these columns will be loaded. These columns are also present in the METdbLoad/sql/mv_mysql.sql file. However, these columns need to be added to the METdbLoad/sql/updates/update_for_6_0_beta6.sql since this hasn't been included in previous update_for_x_y.sql file_s

bikegeek added a commit that referenced this issue Sep 13, 2024
…>.sql was created

Added the LODDS, ORSS, EDS, SEDS, EDI, SEDI, and BAGSS and their corresponding bootstrap columns (bcl, bcu, ncl, and ncu)
@bikegeek
Copy link
Collaborator

It appears that the update_x_y_.sql is not needed, upon looking at a recently created database, these 7 columns and their corresponding bootstrap columns are already present.

Closing this issue as already completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: load Tasks related to the database loading component: METdataio priority: high High Priority requestor: NOAA/CPC NOAA Climate Prediction Center type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

No branches or pull requests

3 participants