Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2648 mode_cts #2655

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Feature #2648 mode_cts #2655

merged 7 commits into from
Aug 21, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Aug 18, 2023

Expected Differences

I'm including in this pull request 4 substantive changes.
You'll see that 177 files are modified but 167 of those are just one-line config file updates.

  1. Adding 7 new statistics to the end of the MODE CTS line type, as requested. This includes updates to the user's guide to list them.
  • Please see changes in mode_columns.h, mode_exec.cc, and mode.rst.
  1. Updating the version number in the code from 11.1.0 to 12.0.0. Since the output line types are changing, now is the time to update the version number. This includes:
  • Change the version number listed in util_contstants.h.
  • Add header table files for the new version in met_header_columns_v12.0.txt, met_12_0_0.hdr, update the MODE CTS columns, and update 2 Makefiles to install the new files.
  • Changes to a whopping 167 configuration files! Just changing version = "V11.1.0"; to version = "V12.0.0"; in all the files named *Config*.

Unrelated to this GitHub issue, but worth noting:

  1. Modify logic in testing.yml to keep it consistent with a recent PR for the main_v11.1 branch.
  2. Delete .find_grid_by_name.h.swp that was inadvertently added to the repo at some point.
  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes]

    If yes, please describe:

    Adds 7 new columns to the MODE CTS output files. Changes the version number of the MET output from 11.1.0 to 12.0.0.

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran make install and make test locally to confirm that MODE runs well. Reviewed newly generated values in the 7 new columns of the MODE CTS output and confirmed made sure they're at least reasonable.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review the documentation changes via RTD. Please review the substantive code changes, looking for typos and mistakes. You can basically ignore the config file changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    No new tests are needed since the existing set of tests already generates MODE CTS output many times.

  • Will this PR result in changes to the test suite? [YES]

    If yes, describe the new output and/or changes to the existing output:

    Basically everything will change since the version number is changing from 11.1.0 to 12.0.0. That'll make the diff step very, very slow and we'll want to update the reference the develop-ref version ASAP after this PR is merged.

Please do download and view at least some of the MODE CTS difference files and confirm that the newly added stats are correct.

  • Please complete this pull request review by [Tuesday 8/22/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ion-update. Also, define the branch_name using the truth_data_version rather than the actual branch name. This was added to main_v11.1 by PR#2653. This will keep the main_v11.1 and develop logic consistent.
… stats to the end of the CTS MODE output and updating the user's guide.
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were checked for spelling errors and consistency, with everything appearing OK. config files were not reviewed given it was a version number update.

@JohnHalleyGotway JohnHalleyGotway merged commit 1ebc778 into develop Aug 21, 2023
33 of 34 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2648_mode_cts branch August 21, 2023 22:28
JohnHalleyGotway pushed a commit that referenced this pull request Aug 22, 2023
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Daniel Adriaansen <[email protected]>
Co-authored-by: John and Cindy <[email protected]>
Co-authored-by: rgbullock <[email protected]>
Co-authored-by: Randy Bullock <[email protected]>
Co-authored-by: Dave Albo <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: davidalbo <[email protected]>
Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: metplus-bot <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Vigh <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: David Albo <[email protected]>
Co-authored-by: Dan Adriaansen <[email protected]>
fix 2518 dtypes appf docs (#2519)
fix 2531 compilation errors (#2533)
fix #2531 compilation_errors_configure (#2535)
fix #2514 develop clang (#2563)
fix #2575 develop python_convert (#2576)
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
fix #2426 develop buoy (#2475)
fix 2596 main v11.1 rpath compilation (#2614)
fix #2514 main_v11.1 clang (#2628)
fix #2644 develop percentile (#2647)
georgemccabe pushed a commit to dtcenter/METplus that referenced this pull request Aug 30, 2023
Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: Dan Adriaansen <[email protected]>
Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Daniel Adriaansen <[email protected]>
Co-authored-by: Jonathan Vigh <[email protected]>
Co-authored-by: root <root@localhost>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Will Mayfield <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: metplus-bot <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: mrinalbiswas <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: jason-english <[email protected]>
Co-authored-by: John Sharples <[email protected]>
fix GitHub Actions warnings (#1864)
fix #1884 develop PCPCombine {custom} in subtract method (#1887)
fix #1939 develop - failure reading obs when zipped file also exists (#1941)
Closes #1986
fix develop Fix broken documentation links (#2004)
fix #2026 develop StatAnalysis looping (#2028)
fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062)
fix #2070 var list numeric order (#2072)
fix #2087 develop docs_pdf (#2091)
fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099)
Fix for Dockerfile smell DL4000 (#2112)
fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140)
fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101)
fix #2137 develop PointStat -obs_valid_beg/end (#2141)
fix failured introduced by urllib3 (see urllib3/urllib3#2168)
fix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162)
fix #2168 develop - StatAnalysis time shift (#2169)
fix releases. (#2183)
fix #2189 develop - spaces in complex thresholds (#2191)
fix #2179 develop TCPairs fix -diag argument (#2187)
fixes (#2200)
fix diff tests (#2217)
fix automated tests (#2237)
fix #2235 rename multivar_itensity to multivar_intensity_flag (#2236)
fix #2241 Create directory containing -out_stat file (#2242)
fix #2245 use unique run ID to name logger instance (#2247)
fix #2244 develop fix diff tests (#2254)
fixture to set pytest tmpdir (#2261)
fix #1853 develop - PointStat don't require mask variables to be set (#2262)
fix #2279 develop - buoy station file from 2022 (#2280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Enhance MODE CTS output file to include missing categorical statistics, including SEDI
2 participants