Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST Catalog and generate some test data #27

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Nov 8, 2023

No description provided.

@Fokko
Copy link
Contributor Author

Fokko commented Nov 9, 2023

@samansmink
Copy link
Collaborator

samansmink commented Nov 9, 2023

Hey @Fokko thanks for the PR! Yea this is a known issue, check out #28, this should fix it.

Could you update it as well in your workflow?

@Fokko
Copy link
Contributor Author

Fokko commented Nov 9, 2023

@samansmink ah nice one, thanks!

@samansmink
Copy link
Collaborator

Hey @Fokko! I think CI is failing because docker compose is not available in the manylinux image.
However for these tests I think it suffices to have this run only on the ubuntu:18.04 job.
The arm job can be stripped as well because as it is cross compiled, we can not test with it anyway

So could you strip both the linux_arm64 and the linux_amd64_gcc4 from the REST.yml?

@Fokko
Copy link
Contributor Author

Fokko commented Nov 21, 2023

Hey @samansmink thanks for pinging me. Let me check right away!

@Fokko Fokko force-pushed the fd-test-rest branch 21 times, most recently from d9fae26 to c8c0adb Compare November 23, 2023 10:34
@Fokko Fokko force-pushed the fd-test-rest branch 12 times, most recently from 785876f to 182e079 Compare November 24, 2023 08:37
@Fokko
Copy link
Contributor Author

Fokko commented Nov 24, 2023

@samansmink It should pass now. It was a bit of a hassle with the docker-in-docker problem, but let me know what you think!

@samansmink
Copy link
Collaborator

@Fokko Thanks a lot for all the work on this. Having a proper iceberg setup to test against is super useful! I've started CI for the PR

After this gets merged I'll look into using this for more of the tests and implementing the REST Catalog against this

@Fokko
Copy link
Contributor Author

Fokko commented Nov 27, 2023

Hey @samansmink Cool stuff

The spec can be found here: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml

Personally, I like to check the Python objects here to see what the requests/responses are. I think it is easier to read than the yaml. Let me know if you need any help!

@samansmink
Copy link
Collaborator

LGTM, thanks again!

@samansmink samansmink merged commit 56f9f56 into duckdb:main Nov 27, 2023
7 checks passed
mike-luabase pushed a commit to definite-app/duckdb_iceberg that referenced this pull request Oct 27, 2024
Add REST Catalog and generate some test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants