Email parsing improved #1016
Merged
Email parsing improved #1016
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
force-pushed
the
tom/email-parsing
branch
from
f39148c
to
4bf6f53
Compare
tomasstrba
force-pushed
the
tom/email-parsing
branch
from
4bf6f53
to
e5c864f
Compare
mallexxx
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM 👍
Please add valid urls with username validation to test_makeURL_from_addressBarString (like user@localhost/, http://[email protected], https://user:@host etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1148564399326804/1207106552424205/f
iOS PR: duckduckgo/iOS#3436
macOS PR: duckduckgo/macos-browser#3395
What kind of version bump will this require?: Major/Minor/Patch
Description:
Parsing of the email address in the address bar improved
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template