Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email parsing improved #3395

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Email parsing improved #3395

merged 4 commits into from
Oct 24, 2024

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Oct 15, 2024

Task/Issue URL: https://app.asana.com/0/1148564399326804/1207106552424205/f

Description:
Email parsing in the address bar improved

Steps to test this PR:

  1. Verify that typing [email protected] into the address bar triggers search instead of navigation to domain.com

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@tomasstrba tomasstrba self-assigned this Oct 15, 2024
@tomasstrba tomasstrba marked this pull request as ready for review October 15, 2024 09:28
tomasstrba added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Oct 24, 2024
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
-->
Task/Issue URL:
https://app.asana.com/0/1148564399326804/1207106552424205/f
iOS PR: duckduckgo/iOS#3436
macOS PR: duckduckgo/macos-browser#3395
What kind of version bump will this require?: Major/Minor/Patch

**Description**:
Parsing of the email address in the address bar improved
@tomasstrba tomasstrba merged commit 1270bfb into main Oct 24, 2024
18 checks passed
@tomasstrba tomasstrba deleted the tom/email-parsing branch October 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants