Fix #3298: Add support for Xcode 16 #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URLOpener protocol and Apple's UIApplication shared the same signature for url opening function. This resulted in ambiguous compile time error. Code is now simplified and still allows to be used in mocks.
In iOS 18 Apple added a new field to UIViewController named `tab`. It causes ambiguity and has to be renamed. Source https://developer.apple.com/documentation/uikit/uiviewcontroller/4434584-tab
iccub
commented
Aug 31, 2024
|
@iccub Thanks! I'll take a look at this on Monday and get back to you. |
samsymons
approved these changes
Sep 4, 2024
samsymons
added a commit
that referenced
this pull request
Sep 9, 2024
# By Christopher Brind (4) and others # Via Alessandro Boron (1) and others * main: (27 commits) Bump C-S-S to 6.14.1 (#3331) DuckPlayer Launch Experiment for iOS (#3328) defer loading the tab switcher button until view did load (#3326) Release 7.136.0-3 (#3324) Release PR: Check for the negative attribution case (#3311) fix tab switcher crashes (speculative fix) (#3319) Onboarding highlights feature flag setup (#3308) Release 7.136.0-2 (#3320) Attempt to fix dissapearing privacy icon (#3317) Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313) Bump BSK with C-S-S to 6.14.0 (#3314) ensure no atb or app version sent with pixel (#3315) Fix #3298: Add support for Xcode 16 (#3299) Fix Keychain Debug view controller segue (#3310) Release 7.136.0-1 (#3309) Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305) [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290) usage segmentation (#3263) Fix wrong URL displayed for auth dialog (#3307) iOS Integration of BSK Onboarding (#3282) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: #3298 & https://app.asana.com/0/414709148257752/1208200157992058/f
Tech Design URL:
CC:
Description:
Resolves #3298
This PR allows this repo to be compiled with Xcode 16.
Two changes had to be made:
In iOS 18 Apple added a new field to UIViewController named
tab.It causes ambiguity and has to be renamed.
Source https://developer.apple.com/documentation/uikit/uiviewcontroller/4434584-tab
I renamed it to
_tab, I am open to any other rename suggestionThe URLOpener protocol and Apple's UIApplication shared the same
signature for url opening function. This resulted in ambiguous compile
time error.
Code is now simplified and still allows to be used in mocks.
Changes I made should be backwards compatible and work in Xcode 15 as well
Steps to test this PR:
These steps are more for devs than QA
QA STR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
No UI changes in this PR
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template