Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defer loading the tab switcher button until view did load #3326

Merged
merged 1 commit into from
Sep 5, 2024
Merged

defer loading the tab switcher button until view did load #3326

merged 1 commit into from
Sep 5, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414709148257752/1208092544762425/f
Tech Design URL:
CC: @bwaresiak

Description:
Defer loading the tab switcher button until view did load to avoid Lottie trying to do something with the view hierarchy when not available.

Steps to test this PR:

  1. On the phone, open, close and re-order tabs. Make sure tab switcher button reflects correct state.
  2. On the iPad, open, close and re-order tabs. Make sure tab switcher button reflects correct state.
  3. Enable "app lock" from settings. Background app. Ensure blank snapshot view is correct. Foreground app and open / close tabs.
  4. Launch the app using a link from cold and while in the background.

@brindy brindy requested review from dus7 and removed request for dus7 September 5, 2024 10:42
dus7
dus7 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@brindy brindy merged commit 3812b58 into main Sep 5, 2024
29 checks passed
@brindy brindy deleted the brindy/defer-tabswitcherbutton-init branch September 5, 2024 13:38
samsymons added a commit that referenced this pull request Sep 9, 2024
@samsymons
Merge branch 'main' into sam/set-vpn-user-agent
a436229 
# By Christopher Brind (4) and others
# Via Alessandro Boron (1) and others
* main: (27 commits)
  Bump C-S-S to 6.14.1 (#3331)
  DuckPlayer Launch Experiment for iOS (#3328)
  defer loading the tab switcher button until view did load (#3326)
  Release 7.136.0-3 (#3324)
  Release PR: Check for the negative attribution case (#3311)
  fix tab switcher crashes (speculative fix) (#3319)
  Onboarding highlights feature flag setup (#3308)
  Release 7.136.0-2 (#3320)
  Attempt to fix dissapearing privacy icon (#3317)
  Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313)
  Bump BSK with C-S-S to 6.14.0 (#3314)
  ensure no atb or app version sent with pixel (#3315)
  Fix #3298: Add support for Xcode 16 (#3299)
  Fix Keychain Debug view controller segue (#3310)
  Release 7.136.0-1 (#3309)
  Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305)
  [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290)
  usage segmentation (#3263)
  Fix wrong URL displayed for auth dialog (#3307)
  iOS Integration of BSK Onboarding (#3282)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dus7 dus7 dus7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @dus7