Enable credentials import promo for all users #3427
Merged
+6
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
amddg44
approved these changes
Oct 16, 2024
graeme
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Oct 21, 2024
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f iOS PR: duckduckgo/iOS#3427 macOS PR: duckduckgo/macos-browser#3383 What kind of version bump will this require?: Major **Optional**: Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f Tech Design URL: https://app.asana.com/0/1202926619870900/1208502988382869/f **Description**: - We're rolling out [✓ Promote password import in autofill menu [2w]](https://app.asana.com/0/0/1201480346793878) and the conversion rate seems pretty decent. If we expand the addressable userbase we're likely to improve the user experience of many more users. - With [✓ Promote password import in autofill menu [2w]](https://app.asana.com/0/0/1201480346793878) we're promoting import to <7 days users with less than 10 passwords saved. - To make this promotion even more impactful, we can expand the coverage to existing users, but to make it impactful we'll need more lax heuristics and a way for users to dismiss this promo. **Steps to test this PR**: [Test Instructions](https://app.asana.com/0/1202926619870900/1208543152554655) <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f
Description:
Just a BSK bump to allow for duckduckgo/macos-browser#3383
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template