Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastlane to 2.225.0 #3462

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update fastlane to 2.225.0 #3462

merged 1 commit into from
Oct 21, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 21, 2024

Task/Issue URL: https://app.asana.com/0/1203301625297703/1208583505730567/f

Steps to test this PR:

  1. Verify that CI is green
  2. Call bundle exec fastlane sync_signing username:<your_ddg_email> and verify that it completes successfully.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from quanganhdo October 21, 2024 13:59
quanganhdo
quanganhdo approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastlane.tools finished successfully 🎉

@ayoy ayoy merged commit 29e974f into main Oct 21, 2024
16 checks passed
@ayoy ayoy deleted the dominik/fastlane-update branch October 21, 2024 14:11
samsymons added a commit that referenced this pull request Oct 21, 2024
@samsymons
Merge branch 'main' into sam/remove-appdependencyprovider-mocks
888de8c 
# By Dominik Kapusta (1) and others
# Via GitHub
* main:
  Update fastlane to 2.225.0 (#3462)
  Enable credentials import promo for all users (#3427)
  Pixel retrying (#3358)

# Conflicts:
#	DuckDuckGoTests/MockDependencyProvider.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanganhdo quanganhdo quanganhdo approved these changes

Assignees

@quanganhdo quanganhdo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @quanganhdo