-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use New Tab Page implementation without customization features #3453
Conversation
@dus7 I went through the onboarding and the dax dialogs are shown properly. Thanks for taking care of this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
had some problems with sync at first, but worked subsequently so some kind of race condition not related to this PR.
Also favorites favicons didn't update in real time after the sync, but not too bothered by that.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208547223289955/f
Tech Design URL:
CC:
Description:
Uses
NewTabPageController
as a home controller, but removes new tab page customization capabilities based onnewTabPageSections
feature flag state. Existing features of Home Screen should remain unchanged.Summary of changes done in this PR:
SimpleNewTabPageView
now serving as a view for new tab page without customization features. Created based on the fully featuredNewTabPageView
.Steps to test this PR:
Dax onboarding
Basic functionality
Toolbar menu items
Sync
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template