Remove HomePageViewController code #3454
Conversation
dus7
force-pushed
the
mariusz/remove-old-home-code
branch
from
9eb444c
to
0653f8e
Compare
dus7
requested review from
a team and
federicocappelli
and removed request for
a team
|
Hi @dus7 I have no context about these changes and the task is empty, could you provide some info and testing steps? |
| @@ -169,3 +169,12 @@ struct HomeMessageButtonViewModel { | |||
| let action: () async -> Void | |||
|
|
|||
| } | |||
|
|
|||
| private extension RemoteAction { | |||
There was a problem hiding this comment.
Extracted out of HomeMessageViewSectionRenderer.swift which was deleted.
| @@ -83,13 +84,6 @@ class FavoritesHomeViewSectionRenderer: NSObject, HomeViewSectionRenderer { | |||
| return Constants.defaultHeaderHeight | |||
| } | |||
|
|
|||
| func install(into controller: HomeViewController) { | |||
There was a problem hiding this comment.
This one is no longer necessary since there is no HomeViewController.
| @@ -43,7 +43,8 @@ class FavoritesHomeViewSectionRenderer: NSObject, HomeViewSectionRenderer { | |||
| static let defaultHeaderHeight: CGFloat = 20 | |||
| static let horizontalMargin: CGFloat = 2 | |||
| static let largeModeMargin: CGFloat = 24 | |||
|
|
|||
| static let sideInsets: CGFloat = 25 | |||
There was a problem hiding this comment.
Extracted from HomeViewSectionRenderers.swift file which was deleted.
| @@ -27,21 +27,6 @@ import os.log | |||
|
|
|||
| final class HomePageConfiguration: HomePageMessagesConfiguration { | |||
|
|
|||
| enum Component: Equatable { | |||
There was a problem hiding this comment.
Removed since it was used only by HomeViewController which is also removed.
Hi, I added a few inline comments and an initial PR link in the description. This PR does not cause any UI and/or logic changes. All the modifications were done in previous one (#3453). This is just removing unused code. |
Task/Issue URL: https://app.asana.com/0/72649045549333/1208547223289954/f
Tech Design URL:
CC: @brindy
Description:
This is a follow up after #3453.
Removes unused code related to HomePageViewController. Home renderers abstraction was also removed, though the implementation itself is used in both Bookmarks controller and to show Favorites while editing URL on non-home tab.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template