DuckPlayer updates and rewrites #3455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
afterxleep
force-pushed
the
daniel/dp.new.tab.base
branch
from
358b3a6
to
670f24d
Compare
|
Code LGTM, but there's an issue I can reproduce on device, details here |
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift # DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandling.swift # DuckDuckGo/TabViewController.swift # DuckDuckGoTests/YoutublePlayerNavigationHandlerTests.swift
Bunn
reviewed
Oct 22, 2024
| // This is to be used in DecidePolicy For to prevent the webView | ||
| // from opening the Youtube app on user-triggered links | ||
| @MainActor | ||
| func shouldCancelNavigation(navigationAction: WKNavigationAction, webView: WKWebView) -> Bool { |
There was a problem hiding this comment.
Maybe add a test case for this?
Bunn
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208563377656003/f
Tech Design URL:
CC:
Description:
DuckPlayer Updates
decidePolicylogic and more stuff fromTabViewController🎉Open In New tab Updates
Steps to test this PR:
Unit tests cover base DuckPlayer navigation scenarios, but you can:
Note: No new tab functionality is present in this PR.