-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DuckPlayer updates and rewrites #3455
base: main
Are you sure you want to change the base?
Conversation
|
358b3a6
to
670f24d
Compare
Code LGTM, but there's an issue I can reproduce on device, details here |
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift # DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandling.swift # DuckDuckGo/TabViewController.swift # DuckDuckGoTests/YoutublePlayerNavigationHandlerTests.swift
// This is to be used in DecidePolicy For to prevent the webView | ||
// from opening the Youtube app on user-triggered links | ||
@MainActor | ||
func shouldCancelNavigation(navigationAction: WKNavigationAction, webView: WKWebView) -> Bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a test case for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes fixed the issue I was having
Task/Issue URL: https://app.asana.com/0/0/1208563377656003/f
Tech Design URL:
CC:
Description:
DuckPlayer Updates
decidePolicy
logic and more stuff fromTabViewController
🎉Open In New tab Updates
Steps to test this PR:
Unit tests cover base DuckPlayer navigation scenarios, but you can:
Note: No new tab functionality is present in this PR.