-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DuckPlayer updates and rewrites #3455
Open
afterxleep
wants to merge
34
commits into
main
Choose a base branch
from
daniel/dp.new.tab.base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
6fc8a2e
Open DuckPlayer Videos in New Tab #1
afterxleep 5c75a0c
Handle JS Based navigation
afterxleep 425ec8f
Add Setting
afterxleep 0fef7ec
Added Unit tests
afterxleep e3510f0
Added Feature Flag
afterxleep fe9c60c
Merge branch 'main' into daniel/dp.new.tab.base
afterxleep 20ea632
Correct Feature Flag
afterxleep 5212141
Use Local navigationType instead
afterxleep c63c339
Fix unit tests
afterxleep 5dd2f22
Adding Pixels
afterxleep 44bd50e
Only trigger JS Navigation if not WatchInYoutube
afterxleep d59d700
Default to true
afterxleep b42f186
Updated DuckPlayer logic to base on URL changes
afterxleep c3d184f
Updated Navigation
afterxleep c0098ae
Fixes back navigation issue
afterxleep 5ee35b5
Improved Duck Navigation Handling
afterxleep da66c1f
Add Documentation
afterxleep 54b9d6f
Added tests for URL navigation
afterxleep f12cdb1
Improve back Navigation
afterxleep 81ccbd4
Added backForward navigation
afterxleep 1e61ea7
Handler optimizations
afterxleep 1c39641
Fixed OpenInYoutube navigation and added test
afterxleep e0db486
Fixed age restricted video
afterxleep 8186c52
Make back-forward navigation safe
afterxleep 670f24d
Remove DuckPlayer Experiment logic
afterxleep dd37f16
Remove Experiment from tests
afterxleep 55d1a9d
Update DuckPlayer load timer
afterxleep 52ca138
Moves the stopLoading to happen after the delay
afterxleep ccda462
Reduce Request time
afterxleep db8970c
Properly handle Youtube Player internal links
afterxleep 7449f76
Update navigation cancel handler
afterxleep c390464
Point to BSK temp branch
afterxleep 67a118a
Merge branch 'main' into daniel/dp.new.tab.base
afterxleep 419a253
Update back navigation
afterxleep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a test case for this?