This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: Listeners for Create Conversation controllers #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerotire
approved these changes
Feb 2, 2024
wadedvsa
approved these changes
Feb 2, 2024
jerotire
added a commit
that referenced
this pull request
Feb 16, 2024
* feat: OLCS packages to dev-project/messaging (#24) * feat: Internal messaging - Reply to a message - MVP (#18) * feat: Conversation Reply. Form complete with post to non functional BE. * feat: Dispatch reply to BE. Hide attachment. * feat: .phpstorm.meta.php for ocls-internal * fix: Alias Create for readability * fix: Remove strong type from close factory (#25) * fix: On successful message reply, clear the textarea (#33) * feat: Composer update for transfer/common after main merge * fix: After replying to a conversation, redirect to prevent re-submit (#41) * fix: After replying to a conversation, redirect to prevent re-submit * feat: Add flash message * feat: Messaging user level disable/enable (#37) * feat: Disable/enabling messaging * feat: Show/hide menu disable/enable commands. fix: Messaging around enable/disable * fix: Side navigation to work for all conversation section * fix: RouteParam added for all conversation controllers * feat: Unit tests for cotroller and route param * feat: Bump olcs-transfer * fix: Non local white screens when using strong types for the container (#45) * fix: Non local white screens when using strong types for the container (tests) (#47) * feat: Update messaging disable text for new AC. (#48) * feat: Create Conversation form & template (#6) * First Commit of form * Changed route to get add action * Organisation form list service * Added connection to query * modified category * Added organisatin and drop down sub category * added new controller form alter fn, removed organisation * removed broken query * Add usage of ByLicenceToOrganisation for licence list * Review suggestions * Remove extra case; Whitespace edits * Choose query based on param presence * Abstract & split controller * Review comments and housekeeping * Remove unused code for tweaking route match * Remove asserts; Whitespace * fix: Remove strong type from close factory * Fix inconsistent label * Renaming * Add data service and use in form * Update transfer * wip: so far * fix: introduced redirect by mistake for localtest * fix: reverted EnvironmentComplaintController to main * fix: remove dd * Redirection config * Whitespace * Remove unused from config * Use licence id from response to redirect * Bump transfer & common * Review suggestions --------- Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: wadedvsa <[email protected]> Co-authored-by: James Wragg <[email protected]> * fix: Listeners for Create Conversation controllers (#58) * Fix config to use listeners * Remove old class --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Add horizontal navgation to enable/disable messaging page (#72) * feat: Task messaging filter (home page) (#76) * feat: Task messaging filter (home page) * feat: olcs-transfer composer bump * chore: removed DataService and use one in common * Revert "chore: removed DataService and use one in common" This reverts commit 12898f1. * chore: moved dataservice for applicno to common (#80) * chore: removed DataService and use one in common * bump: olcs-common * chore: bump olcs-common and olcs-transfer * feat: Extend messaging to applications (#81) * feat: Extend support of messaging to application nav * feat: Extend support of messaging to application nav * feat: Strong type aliases * fix: Cleaner controller code * fix: declare strict_types * Revert "fix: Cleaner controller code" This reverts commit 7650b45. * fix: PR change to thrown exception * feat: Bump olcs-common * fix: Update route param test for application routes (#83) * fix: Add missing licence (and application) headers to a few messaging pages (#85) * fix: interop > psr for container and removal of createService for factories (#89) * fix: remove createService and interop for ApplicationCreateConversationControllerFactory * fix: removed interop container interface for LicenceCreateConversationControllerFactory and cleanup * fix: swap interop for psr for container in LicenceEnableDisableMessagingControllerFactory * fix: swap interop for psr for container in RouteParam/Conversation * fix: swap interop for psr for container in RouteParam/ConversationTest & cleanup imports * fix: swap interop for psr for container in ApplicationCloseConversationControllerFactory * fix: swap interop for psr for container in ApplicationConversationListControllerFactory * fix: swap interop for psr for container in ApplicationConversationMessagesControllerFactory * chore: revert composer.json/lock to use non-messaging project branches (#90) * chore: form annotation changes (#91) --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]>
wadedvsa
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: OLCS packages to dev-project/messaging (#24) * feat: Internal messaging - Reply to a message - MVP (#18) * feat: Conversation Reply. Form complete with post to non functional BE. * feat: Dispatch reply to BE. Hide attachment. * feat: .phpstorm.meta.php for ocls-internal * fix: Alias Create for readability * fix: Remove strong type from close factory (#25) * fix: On successful message reply, clear the textarea (#33) * feat: Composer update for transfer/common after main merge * fix: After replying to a conversation, redirect to prevent re-submit (#41) * fix: After replying to a conversation, redirect to prevent re-submit * feat: Add flash message * feat: Messaging user level disable/enable (#37) * feat: Disable/enabling messaging * feat: Show/hide menu disable/enable commands. fix: Messaging around enable/disable * fix: Side navigation to work for all conversation section * fix: RouteParam added for all conversation controllers * feat: Unit tests for cotroller and route param * feat: Bump olcs-transfer * fix: Non local white screens when using strong types for the container (#45) * fix: Non local white screens when using strong types for the container (tests) (#47) * feat: Update messaging disable text for new AC. (#48) * feat: Create Conversation form & template (#6) * First Commit of form * Changed route to get add action * Organisation form list service * Added connection to query * modified category * Added organisatin and drop down sub category * added new controller form alter fn, removed organisation * removed broken query * Add usage of ByLicenceToOrganisation for licence list * Review suggestions * Remove extra case; Whitespace edits * Choose query based on param presence * Abstract & split controller * Review comments and housekeeping * Remove unused code for tweaking route match * Remove asserts; Whitespace * fix: Remove strong type from close factory * Fix inconsistent label * Renaming * Add data service and use in form * Update transfer * wip: so far * fix: introduced redirect by mistake for localtest * fix: reverted EnvironmentComplaintController to main * fix: remove dd * Redirection config * Whitespace * Remove unused from config * Use licence id from response to redirect * Bump transfer & common * Review suggestions --------- Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: wadedvsa <[email protected]> Co-authored-by: James Wragg <[email protected]> * fix: Listeners for Create Conversation controllers (#58) * Fix config to use listeners * Remove old class --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Add horizontal navgation to enable/disable messaging page (#72) * feat: Task messaging filter (home page) (#76) * feat: Task messaging filter (home page) * feat: olcs-transfer composer bump * chore: removed DataService and use one in common * Revert "chore: removed DataService and use one in common" This reverts commit 12898f1. * chore: moved dataservice for applicno to common (#80) * chore: removed DataService and use one in common * bump: olcs-common * chore: bump olcs-common and olcs-transfer * feat: Extend messaging to applications (#81) * feat: Extend support of messaging to application nav * feat: Extend support of messaging to application nav * feat: Strong type aliases * fix: Cleaner controller code * fix: declare strict_types * Revert "fix: Cleaner controller code" This reverts commit 7650b45. * fix: PR change to thrown exception * feat: Bump olcs-common * fix: Update route param test for application routes (#83) * fix: Add missing licence (and application) headers to a few messaging pages (#85) * fix: Disable reply on closed conversations * fix: Merge bug * fix: Merge issues * fix: Merge bugs * fix: Merge error * chore: Factory cleanup --------- Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: James Wragg <[email protected]> Co-authored-by: James Wragg <[email protected]>
jerotire
added a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: OLCS packages to dev-project/messaging (dvsa/olcs-internal#24) * feat: Internal messaging - Reply to a message - MVP (dvsa/olcs-internal#18) * feat: Conversation Reply. Form complete with post to non functional BE. * feat: Dispatch reply to BE. Hide attachment. * feat: .phpstorm.meta.php for ocls-internal * fix: Alias Create for readability * fix: Remove strong type from close factory (dvsa/olcs-internal#25) * fix: On successful message reply, clear the textarea (dvsa/olcs-internal#33) * feat: Composer update for transfer/common after main merge * fix: After replying to a conversation, redirect to prevent re-submit (dvsa/olcs-internal#41) * fix: After replying to a conversation, redirect to prevent re-submit * feat: Add flash message * feat: Messaging user level disable/enable (dvsa/olcs-internal#37) * feat: Disable/enabling messaging * feat: Show/hide menu disable/enable commands. fix: Messaging around enable/disable * fix: Side navigation to work for all conversation section * fix: RouteParam added for all conversation controllers * feat: Unit tests for cotroller and route param * feat: Bump olcs-transfer * fix: Non local white screens when using strong types for the container (dvsa/olcs-internal#45) * fix: Non local white screens when using strong types for the container (tests) (dvsa/olcs-internal#47) * feat: Update messaging disable text for new AC. (dvsa/olcs-internal#48) * feat: Create Conversation form & template (dvsa/olcs-internal#6) * First Commit of form * Changed route to get add action * Organisation form list service * Added connection to query * modified category * Added organisatin and drop down sub category * added new controller form alter fn, removed organisation * removed broken query * Add usage of ByLicenceToOrganisation for licence list * Review suggestions * Remove extra case; Whitespace edits * Choose query based on param presence * Abstract & split controller * Review comments and housekeeping * Remove unused code for tweaking route match * Remove asserts; Whitespace * fix: Remove strong type from close factory * Fix inconsistent label * Renaming * Add data service and use in form * Update transfer * wip: so far * fix: introduced redirect by mistake for localtest * fix: reverted EnvironmentComplaintController to main * fix: remove dd * Redirection config * Whitespace * Remove unused from config * Use licence id from response to redirect * Bump transfer & common * Review suggestions --------- Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: wadedvsa <[email protected]> Co-authored-by: James Wragg <[email protected]> * fix: Listeners for Create Conversation controllers (dvsa/olcs-internal#58) * Fix config to use listeners * Remove old class --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Add horizontal navgation to enable/disable messaging page (dvsa/olcs-internal#72) * feat: Task messaging filter (home page) (dvsa/olcs-internal#76) * feat: Task messaging filter (home page) * feat: olcs-transfer composer bump * chore: removed DataService and use one in common * Revert "chore: removed DataService and use one in common" This reverts commit 12898f1a8d72d96f1cb448e0d0bbd1da45e8908b. * chore: moved dataservice for applicno to common (dvsa/olcs-internal#80) * chore: removed DataService and use one in common * bump: olcs-common * chore: bump olcs-common and olcs-transfer * feat: Extend messaging to applications (dvsa/olcs-internal#81) * feat: Extend support of messaging to application nav * feat: Extend support of messaging to application nav * feat: Strong type aliases * fix: Cleaner controller code * fix: declare strict_types * Revert "fix: Cleaner controller code" This reverts commit 7650b454036e4c1f2c1badae5b416434c5b82270. * fix: PR change to thrown exception * feat: Bump olcs-common * fix: Update route param test for application routes (dvsa/olcs-internal#83) * fix: Add missing licence (and application) headers to a few messaging pages (dvsa/olcs-internal#85) * fix: interop > psr for container and removal of createService for factories (dvsa/olcs-internal#89) * fix: remove createService and interop for ApplicationCreateConversationControllerFactory * fix: removed interop container interface for LicenceCreateConversationControllerFactory and cleanup * fix: swap interop for psr for container in LicenceEnableDisableMessagingControllerFactory * fix: swap interop for psr for container in RouteParam/Conversation * fix: swap interop for psr for container in RouteParam/ConversationTest & cleanup imports * fix: swap interop for psr for container in ApplicationCloseConversationControllerFactory * fix: swap interop for psr for container in ApplicationConversationListControllerFactory * fix: swap interop for psr for container in ApplicationConversationMessagesControllerFactory * chore: revert composer.json/lock to use non-messaging project branches (dvsa/olcs-internal#90) * chore: form annotation changes (dvsa/olcs-internal#91) --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]>
jerotire
added a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: OLCS packages to dev-project/messaging (dvsa/olcs-internal#24) * feat: Internal messaging - Reply to a message - MVP (dvsa/olcs-internal#18) * feat: Conversation Reply. Form complete with post to non functional BE. * feat: Dispatch reply to BE. Hide attachment. * feat: .phpstorm.meta.php for ocls-internal * fix: Alias Create for readability * fix: Remove strong type from close factory (dvsa/olcs-internal#25) * fix: On successful message reply, clear the textarea (dvsa/olcs-internal#33) * feat: Composer update for transfer/common after main merge * fix: After replying to a conversation, redirect to prevent re-submit (dvsa/olcs-internal#41) * fix: After replying to a conversation, redirect to prevent re-submit * feat: Add flash message * feat: Messaging user level disable/enable (dvsa/olcs-internal#37) * feat: Disable/enabling messaging * feat: Show/hide menu disable/enable commands. fix: Messaging around enable/disable * fix: Side navigation to work for all conversation section * fix: RouteParam added for all conversation controllers * feat: Unit tests for cotroller and route param * feat: Bump olcs-transfer * fix: Non local white screens when using strong types for the container (dvsa/olcs-internal#45) * fix: Non local white screens when using strong types for the container (tests) (dvsa/olcs-internal#47) * feat: Update messaging disable text for new AC. (dvsa/olcs-internal#48) * feat: Create Conversation form & template (dvsa/olcs-internal#6) * First Commit of form * Changed route to get add action * Organisation form list service * Added connection to query * modified category * Added organisatin and drop down sub category * added new controller form alter fn, removed organisation * removed broken query * Add usage of ByLicenceToOrganisation for licence list * Review suggestions * Remove extra case; Whitespace edits * Choose query based on param presence * Abstract & split controller * Review comments and housekeeping * Remove unused code for tweaking route match * Remove asserts; Whitespace * fix: Remove strong type from close factory * Fix inconsistent label * Renaming * Add data service and use in form * Update transfer * wip: so far * fix: introduced redirect by mistake for localtest * fix: reverted EnvironmentComplaintController to main * fix: remove dd * Redirection config * Whitespace * Remove unused from config * Use licence id from response to redirect * Bump transfer & common * Review suggestions --------- Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: wadedvsa <[email protected]> Co-authored-by: James Wragg <[email protected]> * fix: Listeners for Create Conversation controllers (dvsa/olcs-internal#58) * Fix config to use listeners * Remove old class --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Add horizontal navgation to enable/disable messaging page (dvsa/olcs-internal#72) * feat: Task messaging filter (home page) (dvsa/olcs-internal#76) * feat: Task messaging filter (home page) * feat: olcs-transfer composer bump * chore: removed DataService and use one in common * Revert "chore: removed DataService and use one in common" This reverts commit 12898f1a8d72d96f1cb448e0d0bbd1da45e8908b. * chore: moved dataservice for applicno to common (dvsa/olcs-internal#80) * chore: removed DataService and use one in common * bump: olcs-common * chore: bump olcs-common and olcs-transfer * feat: Extend messaging to applications (dvsa/olcs-internal#81) * feat: Extend support of messaging to application nav * feat: Extend support of messaging to application nav * feat: Strong type aliases * fix: Cleaner controller code * fix: declare strict_types * Revert "fix: Cleaner controller code" This reverts commit 7650b454036e4c1f2c1badae5b416434c5b82270. * fix: PR change to thrown exception * feat: Bump olcs-common * fix: Update route param test for application routes (dvsa/olcs-internal#83) * fix: Add missing licence (and application) headers to a few messaging pages (dvsa/olcs-internal#85) * fix: Disable reply on closed conversations * fix: Merge bug * fix: Merge issues * fix: Merge bugs * fix: Merge error * chore: Factory cleanup --------- Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Jamie_gordon_1 <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: James Wragg <[email protected]> Co-authored-by: James Wragg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix listeners for Create Conversation controllers
Related issue: VOL-4681
Before submitting (or marking as "ready for review")