feat: Extend messaging to applications

[wadedvsa]

Description

Extend support of messaging to application routes

Related issue: VOL-4921

Before submitting (or marking as "ready for review")

• Does the pull request title follow the conventional commit specification?
• Have you performed a self-review of the code
• Have you have added tests that prove the fix or feature is effective and working
• Did you make sure to update any documentation relating to this change?

[jerotire]

Should we throw something more generic for not OK? And pipe in the response code/body too? More things could go wrong with a response not OK other than not found.

[jerotire]

Also worth noting that if the backend returns a 404, an exception is thrown anyways:
vendor/olcs/olcs-common/Common/src/Common/Service/Cqrs/Query/QueryService.php:132

That block catches things like 403, 400 and server exception too. And re-throws.

[wadedvsa]

What do you think instead? Having a look around for if \(\!.*isOk\(\)\) yields various throws or flash error unknown error messages. There's a few that extend AbstractInternalController and that has handleErrors but that's not in the class hierarchy here.

[jerotire]

Personally, I'd throw new \Exception('Unexpected error when querying licence for organisation ID. Response: HTTP ' . $queryResponse->getStatusCode() . ' :: ' . $queryResponse->getBody());

[jerotire]

404, 400, 403 and 500 are already handled (thrown) in the query/command service. Thus, this is everything else, unexpected etc....

[jerotire]

and that query handler (Licence) uses fetchById which will throw Exception\NotFoundException which will HTTP 404.
\Dvsa\Olcs\Api\Controller\GenericController

} catch (Exception\NotFoundException $ex) {
            return $this->response()->notFound();