Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title is breaking on dashboard #198

Closed
jolheiser opened this issue Aug 5, 2020 · 1 comment · Fixed by #199
Closed

Title is breaking on dashboard #198

jolheiser opened this issue Aug 5, 2020 · 1 comment · Fixed by #199
Labels
bug Bugs & errors found in Reposilite

Comments

@jolheiser
Copy link
Contributor

This is my fault, sorry. I never noticed because when it fails, it doesn't end up changing the title so without checking console I didn't see.

Dashboard is trying to reference configuration, however it never actually sets or queries for that data.

data: () => ({
auth: Object.assign({}, defaultAuth),
qualifier: ''
}),
components: {
FileEntry
},
metaInfo () {
return {
title:
this.configuration.title !== undefined ? `${this.configuration.title} - ${this.configuration.description}` : 'Reposilite'
}
},

To fix this I would like to get your opinion on two options:

  1. Dashboard can query for config, or
  2. Dashboard can just not update the title.
    • The only caveat to this is if someone goes directly to the URL, I think it would just be an empty title, unless we add a fallback in index.html
@dzikoysk dzikoysk added the bug Bugs & errors found in Reposilite label Aug 5, 2020
@dzikoysk
Copy link
Owner

dzikoysk commented Aug 5, 2020

Well, I'm on vacation and my code review from phone/laptop might be poor 😛. I think we could use hard-coded version of title for dashboard. It might be improved in overall UI (#138) update where the segmentation of views and components will reduce boilerplate code and unnecessary copy-paste between public index and dashboard.

dzikoysk pushed a commit that referenced this issue Aug 6, 2020
dzikoysk pushed a commit that referenced this issue Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs & errors found in Reposilite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants