Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard title #199

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix dashboard title #199

merged 1 commit into from
Aug 6, 2020

Conversation

jolheiser
Copy link
Contributor

Fixes #198

Adds back in a "default" hard-coded title.

If a user navigates to the dashboard from within Reposilite, the title will remain {{ title}} - {{ description }}, but if they go straight to the dashboard URL it will be Reposilite as before.

Perhaps it should still use metaInfo and hard-code set it to something like Dashboard? 🤔
I'm fine with whichever you decide. 🙂

Signed-off-by: jolheiser <[email protected]>
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage     88.83%   88.83%           
  Complexity      491      491           
=========================================
  Files            60       60           
  Lines          1324     1324           
  Branches        137      137           
=========================================
  Hits           1176     1176           
  Misses           97       97           
  Partials         51       51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6803545...3c8bb3e. Read the comment docs.

Copy link
Owner

@dzikoysk dzikoysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's enough for now, thanks :)

@dzikoysk dzikoysk merged commit 07afef7 into dzikoysk:master Aug 6, 2020
@jolheiser jolheiser deleted the fix-dashboard branch August 6, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title is breaking on dashboard
2 participants