Minor fixes from ceo branch #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous commit was the cherry-picked 5cd55dd
**Note that this currently works only for the diary**. The dashboard has not been fixed because it is not currently visible in the CEO branch :) My original plan was to only support metric units, since https://en.wikipedia.org/wiki/Metrication "According to the U.S. Central Intelligence Agency's online The World Factbook (2016), the only countries that have not adopted the metric system are Myanmar (also known as Burma), Liberia and the United States." However, it looks like this project will be US-focused for the forseeable future, and even the UK is beginning to revert its metrication process. So we will support both imperial and metric units with a config option. - Create a new service for this conversion - Have it use metric or imperial based on a config flag - Change all existing distance calculations to use the new service - Add a "suffix" to the service to distinguish between "mi" (miles) and "km" (kilometers) - Change all the templates and the i18n to use the suffix instead of hardcoded values Testing done: - set the config value to false; confirmed that everything is in km - set the config value to true; confirmed that everything is in miles and there were no errors in the console log
This fixes issues in which the labels are partially hidden on some phones, and is a reasonable workaround for the inability to test with multiple phones. We could even consider allowing users to save their perfect height in a local setting later so they don't have to keep changing the settings every time. I tried to do this automatically, but failed with the current UI e-mission/e-mission-docs#679 (comment)
To see if it fixes e-mission/e-mission-docs#679 (comment) It is already a fixed height on iOS because otherwise it doesn't work e-mission@089797e
This was referenced Oct 16, 2021
Merge generic code (primarily stats) from tripaware/ceo_ebike to master
e-mission/e-mission-docs#679
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last two should be cherry-picked and applied as part of a UI-only update.