Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes from ceo branch #800

Merged
merged 5 commits into from
Oct 15, 2021

Commits on Oct 14, 2021

  1. notification open reading

    jleyden authored and shankari committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5cd55dd View commit details
    Browse the repository at this point in the history
  2. Fix formatting error from previous commit

    Previous commit was the cherry-picked
    5cd55dd
    shankari committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    78a9369 View commit details
    Browse the repository at this point in the history
  3. [diary only] Support both imperial and metric units with a config option

    **Note that this currently works only for the diary**. The dashboard has not
    been fixed because it is not currently visible in the CEO branch :)
    
    My original plan was to only support metric units, since
    
    https://en.wikipedia.org/wiki/Metrication
    "According to the U.S. Central Intelligence Agency's online The World Factbook
    (2016), the only countries that have not adopted the metric system are Myanmar
    (also known as Burma), Liberia and the United States."
    
    However, it looks like this project will be US-focused for the forseeable
    future, and even the UK is beginning to revert its metrication process. So we will support both imperial and metric units with a config option.
    
    - Create a new service for this conversion
    - Have it use metric or imperial based on a config flag
    - Change all existing distance calculations to use the new service
    - Add a "suffix" to the service to distinguish between "mi" (miles) and "km"
      (kilometers)
    - Change all the templates and the i18n to use the suffix instead of hardcoded values
    
    Testing done:
    - set the config value to false; confirmed that everything is in km
    - set the config value to true; confirmed that everything is in miles and there
      were no errors in the console log
    shankari committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ac9b816 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Allow users to resize the items

    This fixes issues in which the labels are partially hidden on some phones, and
    is a reasonable workaround for the inability to test with multiple phones.
    We could even consider allowing users to save their perfect height in a local
    setting later so they don't have to keep changing the settings every time.
    
    I tried to do this automatically, but failed with the current UI
    e-mission/e-mission-docs#679 (comment)
    shankari committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    3827130 View commit details
    Browse the repository at this point in the history
  2. Remove % height for the leaflet map on android as well

    To see if it fixes
    e-mission/e-mission-docs#679 (comment)
    
    It is already a fixed height on iOS because otherwise it doesn't work
    e-mission@089797e
    shankari committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a933410 View commit details
    Browse the repository at this point in the history