Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport/can: Rename UXR_CONFIG_CAN_TRANSPORT_MTU #370

Closed

Conversation

yashi
Copy link
Contributor

@yashi yashi commented Sep 26, 2023

Because CAN-FD MTU is fixed, it's not configurable. UXR_CONFIG_CAN_TRANSPORT_MTU is a bit misleading. Thus, this commit rename it to UXR_CAN_TRANSPORT_MTU.

Hope you like it.

Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogs9
Copy link
Member

Please open this PR on top of develop, we only merge releases in master

Because CAN-FD MTU is fixed, it's not configurable.
UXR_CONFIG_CAN_TRANSPORT_MTU is a bit misleading. Thus, this commit
rename it to UXR_CAN_TRANSPORT_MTU.

Signed-off-by: Yasushi SHOJI <[email protected]>
@yashi yashi force-pushed the rename-UXR_CONFIG_CAN_TRANSPORT_MTU branch from 2e18701 to 2bb82ee Compare September 26, 2023 13:26
@yashi yashi requested a review from pablogs9 September 26, 2023 13:26
@pablogs9 pablogs9 changed the base branch from master to develop September 26, 2023 13:35
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogs9
Copy link
Member

Sorry, our Jenkins CI has not been triggered. Could you please close this PR and open a new one targeting develop?

Sorry for the inconvenience.

@yashi yashi closed this Sep 26, 2023
@yashi yashi deleted the rename-UXR_CONFIG_CAN_TRANSPORT_MTU branch September 26, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants