Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport/can: Rename UXR_CONFIG_CAN_TRANSPORT_MTU #371

Conversation

yashi
Copy link
Contributor

@yashi yashi commented Sep 26, 2023

Because CAN-FD MTU is fixed, it's not configurable. UXR_CONFIG_CAN_TRANSPORT_MTU is a bit misleading. Thus, this commit rename it to UXR_CAN_TRANSPORT_MTU.

I've missed the target branch on #370. Hope it works this time.

Because CAN-FD MTU is fixed, it's not configurable.
UXR_CONFIG_CAN_TRANSPORT_MTU is a bit misleading. Thus, this commit
rename it to UXR_CAN_TRANSPORT_MTU.

Signed-off-by: Yasushi SHOJI <[email protected]>
@pablogs9
Copy link
Member

Sorry @yashi, it seems that our CI has some troubles with your remote branch, I have created this one: #372

And CI is running there.

Your authorship is maintained in the commit, so, if you are ok with it, we can merge the new one and close this. Let me know.

@yashi
Copy link
Contributor Author

yashi commented Sep 27, 2023

no problem at all.

@yashi yashi closed this Sep 27, 2023
@yashi
Copy link
Contributor Author

yashi commented Sep 27, 2023

BTW, is it because I have my repo under a different name?

@yashi yashi deleted the rename-UXR_CONFIG_CAN_TRANSPORT_MTU-take2 branch September 27, 2023 10:38
@pablogs9
Copy link
Member

Not sure... but the CI fails to fetch your branch somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants