Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust Perl easyblock to only check for a "man" directory if groff is a dependency #2474

Merged
merged 1 commit into from
Jun 16, 2021
Merged

adjust Perl easyblock to only check for a "man" directory if groff is a dependency #2474

merged 1 commit into from
Jun 16, 2021

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Jun 15, 2021 •
edited
Loading

(created using eb --new-pr)

Required for upcoming Perl-minimal which is required to solve cyclic dependency for makeinfo

@akesandgren akesandgren added this to the next release (4.4.1) milestone Jun 15, 2021
@akesandgren akesandgren requested a review from boegel June 15, 2021 11:42
This was referenced Jun 15, 2021
Merged
Merged
Merged
ocaisa
ocaisa approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test report with the Perl-minimal and this is good to go

@ocaisa
Copy link
Member

ocaisa commented Jun 16, 2021

Test reports in easybuilders/easybuild-easyconfigs#13163

@ocaisa ocaisa merged commit 9c537b1 into easybuilders:develop Jun 16, 2021
@akesandgren akesandgren deleted the 20210615134029_new_pr_JmeUtDWiOZ branch June 16, 2021 08:47
@boegel boegel changed the title Adjust perl.py to only check for a "man" directory if groff is a dependency. adjust Perl easyblock to only check for a "man" directory if groff is a dependency. Jun 21, 2021
@boegel boegel changed the title adjust Perl easyblock to only check for a "man" directory if groff is a dependency. adjust Perl easyblock to only check for a "man" directory if groff is a dependency Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@akesandgren @ocaisa