Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCCcore/9.3.0] groff requires makeinfo as a build dep, which requires Perl, which requires groff; break cyclic dependency by adding Perl-minimal and makeinfo-minimal #13163

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Jun 15, 2021

(created using eb --new-pr)

Depends on easybuilders/easybuild-easyblocks#2474

Solves #12067

…quires groff. Break cyclic redundancy by adding Perl-minimal and makeinfo-minimal.
@akesandgren akesandgren added this to the next release (4.4.1) milestone Jun 15, 2021
@akesandgren akesandgren linked an issue Jun 15, 2021 that may be closed by this pull request
@akesandgren akesandgren changed the title groff requires makeinfo as a build dep, which requires Perl, which requires groff. Break cyclic redundancy by adding Perl-minimal and makeinfo-minimal. [GCCcore/9.3.0] groff requires makeinfo as a build dep, which requires Perl, which requires groff. Break cyclic redundancy by adding Perl-minimal and makeinfo-minimal. Jun 15, 2021
@boegelbot
Copy link
Collaborator

@akesandgren: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/939299803
Output from first failing test suite run:

FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 607, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>GCCcore-[7-9]\.[0-9]).*\.eb$' easyconfigs:

found 2 variants of 'Perl' dependency in easyconfigs using 'GCCcore-9.3' toolchain generation
* version: 5.30.2; versionsuffix:  as dep for set(['any2fasta-0.4.2-GCCcore-9.3.0.eb', 'Circos-0.69-9-GCCcore-9.3.0.eb', 'BioPerl-1.7.7-GCCcore-9.3.0.eb', 'XML-LibXML-2.0205-GCCcore-9.3.0.eb', 'MCL-14.137-GCCcore-9.3.0.eb', 'snpEff-5.0-GCCcore-9.3.0-Java-13-Python-3.8.2.eb', 'Trim_Galore-0.6.6-GCCcore-9.3.0-Python-3.8.2.eb', 'ExifTool-12.00-GCCcore-9.3.0.eb', 'git-2.23.0-GCCcore-9.3.0-nodocs.eb', 'intltool-0.51.0-GCCcore-9.3.0.eb', 'GD-2.71-GCCcore-9.3.0.eb', 'Graphviz-2.44.1-GCCcore-9.3.0-Java-11-Python-3.8.2.eb', 'DFA-0.3.4-GCCcore-9.3.0-Python-3.8.2.eb', 'samclip-0.4.0-GCCcore-9.3.0.eb', 'Graphviz-2.44.1-GCCcore-9.3.0-Java-11.eb', 'parallel-20200522-GCCcore-9.3.0.eb', 'wtdbg2-2.5-GCCcore-9.3.0.eb', 'pydot-1.4.1-GCCcore-9.3.0.eb', 'festival-2.5.0-GCCcore-9.3.0.eb', 'speech_tools-2.5.0-GCCcore-9.3.0.eb', 'canu-2.1.1-GCCcore-9.3.0-Java-11.eb', 'parallel-20200422-GCCcore-9.3.0.eb', 'ITSx-1.1.2-GCCcore-9.3.0.eb', 'Kraken-1.1.1-GCCcore-9.3.0.eb', 'fetchMG-1.0-GCCcore-9.3.0.eb', 'py-aiger-6.1.1-GCCcore-9.3.0-Python-3.8.2.eb', 'DB_File-1.835-GCCcore-9.3.0.eb', 'ProbABEL-0.5.0-GCCcore-9.3.0.eb', 'GitPython-3.1.9-GCCcore-9.3.0-Python-3.8.2.eb'])
* version: 5.30.2; versionsuffix: -minimal as dep for set(['makeinfo-6.7-GCCcore-9.3.0-minimal.eb'])


----------------------------------------------------------------------
Ran 12411 tests in 465.900s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@akesandgren
Copy link
Contributor Author

Test report by @akesandgren
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2474
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.5
See https://gist.github.com/c64c2a0abc396964484e0f3571594638 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2474
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/47f53a673229be968c1075cf02a21396 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2474
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
centos8-eb - Linux centos linux 8.3.2011, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.8
See https://gist.github.com/dc5f6a45de21ea7b4eae4ca04c464392 for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren to fix the failing test an exception should be added for Perl with versionsuffix -minimal in test/easyconfigs/easyconfigs.py

@akesandgren
Copy link
Contributor Author

Yeah, but I don't know how to write that exception, since it (currently) should only be allowed in makeinfo-minimal.
Trying to figure out the code snippets there...

@akesandgren akesandgren force-pushed the 20210615143855_new_pr_Perl5302 branch from e340520 to 359a2b6 Compare June 23, 2021 11:39
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren Thanks for adding the exception!
lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @akesandgren!

@SebastianAchilles SebastianAchilles merged commit 4408411 into easybuilders:develop Jun 23, 2021
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on generoso

PR test command 'EB_PR=13163 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13163 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17606

Test results coming soon (I hope)...

- notification for comment with ID 866791266 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@akesandgren akesandgren deleted the 20210615143855_new_pr_Perl5302 branch June 23, 2021 12:44
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a4367a55179197a39ffb88be7436a7df for a full test report.

@boegel boegel changed the title [GCCcore/9.3.0] groff requires makeinfo as a build dep, which requires Perl, which requires groff. Break cyclic redundancy by adding Perl-minimal and makeinfo-minimal. [GCCcore/9.3.0] groff requires makeinfo as a build dep, which requires Perl, which requires groff; break cyclic dependency by adding Perl-minimal and makeinfo-minimal Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeinfo/6.7-GCCcore-9.3.0 needs perl libraries
4 participants