-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Hypre git location for PETSc 3.11.0 using downloaded dependencies #11947
update Hypre git location for PETSc 3.11.0 using downloaded dependencies #11947
Conversation
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 753923445 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
@branfosj Looks like we have a missing
|
So, this is annoying. If we have Python as a dep (build or standard) then we add |
@branfosj So we should enhance the |
@boegel There is two different issues:
Your suggested fix solves issue 1, but does not solve 2 in this case. This is because Python in 2018b has numpy and mpi4py included. So to fix PETSc here, we would need to move it to have a Python dep and then alter any other easyconfigs that require this version of PETSc. This seems like an overly complicated solution to the problem. Should we instead add an option to the easyblock to disable building Python support? (Or an option to enable building with Python support that defaults to True.) |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 754054300 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegelbot |
Test report by @branfosj |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 754141829 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegelbot |
Test report by @branfosj |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @branfosj! |
(created using
eb --new-pr
)PETSc-3.11.0-foss-2018b-downloaded-deps.eb
downloads various items during the install (as the name suggests). The Hypre github has moved, so the download fails.edit (@boegel): requires
easybuilders/easybuild-easyblocks#2299