Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Hypre git location for PETSc 3.11.0 using downloaded dependencies #11947

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 4, 2021

(created using eb --new-pr)

PETSc-3.11.0-foss-2018b-downloaded-deps.eb downloads various items during the install (as the name suggests). The Hypre github has moved, so the download fails.

edit (@boegel): requires easybuilders/easybuild-easyblocks#2299

@boegel boegel changed the title PETSc: update Hypre git location update Hypre git location for PETSc 3.11.0 using downloaded dependencies Jan 4, 2021
@boegel boegel added this to the next release (4.3.3?) milestone Jan 4, 2021
@boegel
Copy link
Member

boegel commented Jan 4, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11947 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11947 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12362

Test results coming soon (I hope)...

- notification for comment with ID 753923445 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4608e3782d01f8beca16652d1d315077 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 4, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/51335caaa0b501de8ee039b17db00fd3 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 4, 2021

@branfosj Looks like we have a missing Python (build?) dep too:

/usr/bin/env: python: No such file or directory

@branfosj
Copy link
Member Author

branfosj commented Jan 4, 2021

@branfosj Looks like we have a missing Python (build?) dep too:

/usr/bin/env: python: No such file or directory

So, this is annoying. If we have Python as a dep (build or standard) then we add --with-numpy=1 --with-mpi4py=1 to the configure, which are not there otherwise (see https://gist.github.com/boegelbot/fb04fd99bd60660248693e8f644d0c0e#file-petsc-3-11-0-foss-2018b-downloaded-deps_partial-log-L489). This is happening at https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/p/petsc.py#L157

@boegel
Copy link
Member

boegel commented Jan 4, 2021

@branfosj Looks like we have a missing Python (build?) dep too:

/usr/bin/env: python: No such file or directory

So, this is annoying. If we have Python as a dep (build or standard) then we add --with-numpy=1 --with-mpi4py=1 to the configure, which are not there otherwise (see https://gist.github.com/boegelbot/fb04fd99bd60660248693e8f644d0c0e#file-petsc-3-11-0-foss-2018b-downloaded-deps_partial-log-L489). This is happening at https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/p/petsc.py#L157

@branfosj So we should enhance the PETSc easyblock to check whether import numpy and import mpi4py work before enabling those configure options, rather than assuming they come with Python?

@branfosj
Copy link
Member Author

branfosj commented Jan 4, 2021

@boegel There is two different issues:

  1. The current easyblock assumes that numpy and mpi4py will be there if Python is found and enables those options.
  2. If we want to use the Python as a build dependency - to make the minimal change possible here - that enables numpy / mpi4py meaning that we then need Python as a dependency.

Your suggested fix solves issue 1, but does not solve 2 in this case. This is because Python in 2018b has numpy and mpi4py included. So to fix PETSc here, we would need to move it to have a Python dep and then alter any other easyconfigs that require this version of PETSc. This seems like an overly complicated solution to the problem.

Should we instead add an option to the easyblock to disable building Python support? (Or an option to enable building with Python support that defaults to True.)

@boegel
Copy link
Member

boegel commented Jan 4, 2021

@boegel
Copy link
Member

boegel commented Jan 4, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2299"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11947 EB_ARGS="--include-easyblocks-from-pr 2299" /apps/slurm/default/bin/sbatch --job-name test_PR_11947 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12367

Test results coming soon (I hope)...

- notification for comment with ID 754054300 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 4, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/c4796a4fe45fd1f0b58b246afa49af3b for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/78b450369d51a5e40595e156deab7ec7 for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Jan 4, 2021

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u12a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/1923204e7239175ab8cf71f9834f422f for a full test report.

@boegel
Copy link
Member

boegel commented Jan 4, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2299"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11947 EB_ARGS="--include-easyblocks-from-pr 2299" /apps/slurm/default/bin/sbatch --job-name test_PR_11947 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12368

Test results coming soon (I hope)...

- notification for comment with ID 754141829 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 4, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/ceed4ba5067a327bd24c72e8a498ddd1 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cff139383c99c78751fd7e844303f52b for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Jan 4, 2021

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/ac2acb231d049b666c559751c701e525 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 4, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2299
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2624.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/7e5f39c39cacf9ec51fcf56d4bddff39 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 5, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit 5e29db1 into easybuilders:develop Jan 5, 2021
@branfosj branfosj deleted the 20210104104028_new_pr_PETSc3110 branch January 5, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants