Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix AmberTools v20 easyconfig using intel/2020a toolchain #14028
fix AmberTools v20 easyconfig using intel/2020a toolchain #14028
Changes from all commits
339f035
77b79e8
33f18b4
76e4db6
a009b8b
cbc69bf
d0842d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think runtest = "test.serial" should avoid that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
runtest ="test.serial"
I get lots of failures. Full log of the test section in the section below.Lots of failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that is lots of
pmemd
not found failures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then that's something we should report upstreams... I'll ask David
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But somethings off here it should not go into test and run make test, it should go into AmberTools/test and run make test.
Was that the start of the test_step section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the changes in easybuilders/easybuild-easyblocks#2604, I'm still running into test failures after removing the
runtest = False
here... :(There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@branfosj @akesandgren How about getting this merged, and figuring out the problems with the tests in the context of easybuilders/easybuild-easyblocks#2604?
This easyconfig is currently broken hard due to the changes in easybuilders/easybuild-easyblocks#2445, at least this way there's some progress...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just running a test report from my side....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to proceed here. I'm not sure I'll have time to look at easybuilders/easybuild-easyblocks#2604 soon, as it is clearly more complicated than I first thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent a question to the developers about AT testing, no reply yet though.