Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[foss/2018b] poppler v0.70.1 #7069

Merged

Conversation

fizwit
Copy link
Contributor

@fizwit fizwit commented Oct 23, 2018

(created using eb --new-pr)

edit by @boegel: requires #7068 (OpenJPEG)

boegel
boegel previously approved these changes Oct 24, 2018
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after visual check

@boegel boegel added the new label Oct 24, 2018
@boegel
Copy link
Member

boegel commented Nov 2, 2018

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/117d1824a0119140a4617a36e52e58eb for a full test report.

@boegel
Copy link
Member

boegel commented Nov 2, 2018

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in this PR)
node2508.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7ceac9c0870e680fc79ea2d03bdd003e for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Nov 2, 2018
@boegel
Copy link
Member

boegel commented Nov 2, 2018

@fizwit Sanity check fails because libraries are being installed in lib64 rather than lib for me.

It looks like the automatic fallback for lib to lib64 in the EasyBuild framework (cfr. easybuilders/easybuild-framework#2477) doesn't work for a lib entry in dirs, we'll need to fix that...

For now, just dropping lib from dirs makes sense though, since we're already checking for particular files under lib/ anyway?

@boegel
Copy link
Member

boegel commented Nov 2, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 2 (1 easyconfigs in this PR)
node2120.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d1eb0831d3ae68e5602fa378ccad65b2 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 3, 2018

@fizwit The fix for the failing fallback for lib to lib64 in the sanity check is done in easybuilders/easybuild-framework#2649, which will be part of the next EasyBuild release.

Regardless, it still makes sense to simply drop the 'lib' entry in sanity_check_paths here, since we're already checking for particular files in lib/ (and in that case the fallback to checking for files in lib64/ instead does work).

@boegel
Copy link
Member

boegel commented Nov 6, 2018

@fizwit The automated style check is tripping over trailing whitespace on lines 31 & 38:

$ eb --from-pr 7069 --check-style
== temporary log file in case of crash /tmp/eb-z6ZAD4/easybuild-a_rGiW.log

Running style check on 1 easyconfig(s)...

/tmp/eb-z6ZAD4/files_pr7069/p/poppler/poppler-0.70.1-foss-2018b.eb:31:26: W299 trailing whitespace
/tmp/eb-z6ZAD4/files_pr7069/p/poppler/poppler-0.70.1-foss-2018b.eb:38:76: W299 trailing whitespace
[FAIL] /tmp/eb-z6ZAD4/files_pr7069/p/poppler/poppler-0.70.1-foss-2018b.eb

ERROR: One or more style checks FAILED!

@easybuilders easybuilders deleted a comment from boegelbot Nov 7, 2018
@boegel
Copy link
Member

boegel commented Nov 7, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2634.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3602164d19edf590ee87fefd02411352 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 7, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/6aeb6119a86318af33ca28ce25fcadcd for a full test report.

@boegel
Copy link
Member

boegel commented Nov 7, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/87fedf0fcb9d47a5f1e76c1051f84d81 for a full test report.

@boegel boegel added this to the 3.8.0 milestone Nov 7, 2018
@boegel
Copy link
Member

boegel commented Nov 7, 2018

Going in, thanks @fizwit!

@boegel boegel merged commit ab5f560 into easybuilders:develop Nov 7, 2018
@wpoely86
Copy link
Member

@fizwit I'm a bit puzzled by this easyconfig. All dependencies are build dependencies. That cannot be correct? poppler needs libjpeg etc at runtime?

@fizwit fizwit deleted the 20181023131809_new_pr_poppler0701 branch November 14, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants