-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{vis}[foss/2018b] poppler v0.70.1 #7069
{vis}[foss/2018b] poppler v0.70.1 #7069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after visual check
Test report by @boegel |
Test report by @boegel |
@fizwit Sanity check fails because libraries are being installed in It looks like the automatic fallback for For now, just dropping |
Test report by @boegel |
@fizwit The fix for the failing fallback for Regardless, it still makes sense to simply drop the |
@fizwit The automated style check is tripping over trailing whitespace on lines 31 & 38:
|
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @fizwit! |
@fizwit I'm a bit puzzled by this easyconfig. All dependencies are build dependencies. That cannot be correct? poppler needs libjpeg etc at runtime? |
(created using
eb --new-pr
)edit by @boegel: requires
#7068(OpenJPEG
)