fix lib64 fallback for 'lib'/'lib64' dirs entry in sanity_check_paths #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
requested changes
Nov 3, 2018
test/framework/toy_build.py
Outdated
| @@ -1656,6 +1667,17 @@ def test_sanity_check_paths_lib64(self): | |||
| # sanity check passes when lib64 fallback is enabled (by default), since lib/libtoy.a is also considered | |||
| self.test_toy_build(ec_file=test_ec, raise_error=True) | |||
|
|
|||
| # also check with 'lib' in sanity check dirs (special case) | |||
There was a problem hiding this comment.
lib -> lib64 in the comment
akesandgren
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for bug that popped up in easybuilders/easybuild-easyconfigs#7069
For
'lib'or'lib64'entries indirsinsanity_check_paths, the fallback mechanism failed because it checks for entries starting withlib/orlib64/(to avoid that partial matches on something like'library'would trigger the fallback too).