Use Option<String> as service response type #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `tower_service::Service` for `LspService` uses `String` as the response type. Incoming LSP notifications produce a zero-length string response, which isn't fully semantically correct. Rather, incoming client-to-server requests should produce a `Some(String)` response and all other incoming messages (client-to-server notifications or responses) should produce a `None` response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
LspServiceto returnOption<String>responses.Serverto acceptT: Service<Incoming, Response = Option<String>>.The current implementation of
tower_service::ServiceforLspServiceusesStringas the response type. Incoming LSP notifications produce a zero-length string response, which isn't fully semantically correct. Rather, incoming client-to-server requests should produce aSome(String)response and all other incoming messages (client-to-server notifications or responses) should produce aNoneresponse.