Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Option<String> as service response type #116

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Use Option<String> as service response type #116

merged 1 commit into from
Feb 28, 2020

Commits on Feb 28, 2020

  1. Use Option<String> as service response type 

    The current implementation of `tower_service::Service` for `LspService`
uses `String` as the response type. Incoming LSP notifications produce a
zero-length string response, which isn't fully semantically correct.
Rather, incoming client-to-server requests should produce a
`Some(String)` response and all other incoming messages
(client-to-server notifications or responses) should produce a `None`
response.
    @ebkalderon
    ebkalderon committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    162afd3 View commit details
    Browse the repository at this point in the history