Fix OSX CI #1409
Fix OSX CI #1409
Conversation
mindstormjak
force-pushed
the
fix-osx-ci
branch
from
803d0ef
to
f620464
Compare
mindstormjak
force-pushed
the
fix-osx-ci
branch
from
f620464
to
78530e6
Compare
|
@mindstormjak is the electron-builder update required for the CI pipeline fixes? I'd have more confidence merging this without those dependency updates. |
Yes, without the update it runs into this issue electron-userland/electron-builder#6726 |
Alright, then I'd probably have to do some manual testing first. @ebkr do you foresee any pitfalls in updating the electron-loader? On the other hand updating it wouldn't be a bad thing, on the other hand IDK if keeping the mac on the CI pipeline is that important since they're not properly supported either? |
GitHub actions dropped the support for MacOS 11, causing all CI jobs to fail. Updating to MacOS 12 would require updating 3rd party dependencies, namely electron-builder (see PR #1409). MacOS isn't officially supported by this project, and it was added to CI pipeline just because doing so was easy and only required a few lines of config code. Now keeping MacOS on the CI pipeline would require testing that updating electron-builder has no ill side-effects. That work seems to have a low return of investment, so changes are it won't get done anytime soon.
Github recently removed macos 11 from their actions runners.
This bumps the macos version to 12 which is the oldest supported by actions.
Also renamed the test workflow from build to test.