Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MacOS from CI pipeline #1447

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Disable MacOS from CI pipeline #1447

merged 1 commit into from
Oct 1, 2024

Conversation

anttimaki
Copy link
Collaborator

GitHub actions dropped the support for MacOS 11, causing all CI jobs to fail. Updating to MacOS 12 would require updating 3rd party dependencies, namely electron-builder (see PR #1409).

MacOS isn't officially supported by this project, and it was added to CI pipeline just because doing so was easy and only required a few lines of config code. Now keeping MacOS on the CI pipeline would require testing that updating electron-builder has no ill side-effects. That work seems to have a low return of investment, so changes are it won't get done anytime soon.

GitHub actions dropped the support for MacOS 11, causing all CI jobs to
fail. Updating to MacOS 12 would require updating 3rd party
dependencies, namely electron-builder (see PR #1409).

MacOS isn't officially supported by this project, and it was added to
CI pipeline just because doing so was easy and only required a few
lines of config code. Now keeping MacOS on the CI pipeline would
require testing that updating electron-builder has no ill side-effects.
That work seems to have a low return of investment, so changes are it
won't get done anytime soon.
@anttimaki anttimaki requested a review from ebkr September 17, 2024 06:11
@anttimaki
Copy link
Collaborator Author

Merging this without review. It's easy enough to undo if it turns out to be a bad idea.

@anttimaki anttimaki merged commit 87b84ee into develop Oct 1, 2024
5 checks passed
@anttimaki anttimaki deleted the disable-mac-build branch October 1, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant