SiKo with Richtext-Editor #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richtext-Editor: - VTiptapEditor like VTextarea - ERichtext like ETextarea (Form Control) - ApiRichtext like ApiTextarea (Api Auto-Save Control)
|
Aktuelles Aussehen:
Probiert es aus... |
|
Genial dass dus hingebracht hast mit Vuetify! |
manuelmeister
approved these changes
Jul 9, 2020
Replace <br> and <br/> with <br /> to be compatible with HTMLPurifier
Closed
(update snapshot)
Used VueDraggable
Erluabt den direkten vergleich von Vuetify-, E- und Api-Controls
|
Tiptap wird für die weitere Entwicklung auf eine andere Organisation migriert. Sollte aber weiter kein Problem sein. |
pmattmann
commented
Jul 21, 2020
backend/content-type/eCampRichtext/src/Service/RichtextService.php
Outdated
Show resolved
Hide resolved
…ecamp3 into feature/tiptap-editor # Conflicts: # frontend/src/components/form/api/ApiTextField.vue
…nn/ecamp3 into feature/tiptap-editor
vereinheitlicht unbenannt campfilter moved to BaseContentTypeService
…tiptap-editor # Conflicts: # backend/composer.json # backend/composer.lock # backend/module/eCampCore/data/prod/ActivityTypeData.php # backend/module/eCampCore/data/prod/ContentTypeData.php # frontend/src/components/activity/layouts/General.vue
manuelmeister
approved these changes
Jul 26, 2020
usu
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Looks good to me
2 Dinge die sicher noch Improvement brauchen (kann man aber easy nach dem mergen anschauen als separate Issues):
- Titel eines ActivityContent bearbeiten braucht sicher noch Improvement
- Textfeld ohne aktiviertes Richtext: Verwendung von < und > hat eher unschönes Verhalten. Manchmal wird ein Tag "erkannt" und ganzer Textblock gelöscht, manchmal durch
<und>ersetzt
|
Habe für die Punkte von Urban zwei neue Issues erfasst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Richtext-Editor:
Todos:
Replaces #483, #491, #492