Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail images are not properly referenced when writing AASX files #256

Closed
andreas-schilling opened this issue Mar 4, 2024 · 1 comment · Fixed by #263
Closed

Thumbnail images are not properly referenced when writing AASX files #256

andreas-schilling opened this issue Mar 4, 2024 · 1 comment · Fixed by #263

Comments

@andreas-schilling
Copy link
Contributor

Thumbnail images for AASX files are currently simply exported along with other files, but are not properly referenced according to the specification.
This results in the problem, that e.g. the AASX explorer won't display the thumbnail image.
The AASX file as such is not broken or does cause actual errors, but the thumbnail image is kind of dangling inside the AASX.

To be correctly embedded, the file would need to be referenced from the root package, using the http://schemas.openxmlformats.org/package/2006/relationships/metadata/thumbnail relationship type.

I locally tested a fix and would be happy to provide a PR for this.

@FrankSchnicke
Copy link
Contributor

Thank you for bringing this to our attention. We would be very grateful if you would consider contributing a PR!

@twebermartins twebermartins moved this to 🆕 New in Eclipse AAS4J Dev Mar 12, 2024
@twebermartins twebermartins moved this from 🆕 New to 🏗 In progress in Eclipse AAS4J Dev Mar 12, 2024
FrankSchnicke pushed a commit that referenced this issue Mar 14, 2024
* Use correct reference when adding thumbnail images

fix #256

* Fix formatting

* Apply further formatting fixes
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Eclipse AAS4J Dev Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants