Refresh trace viewer after server URL preference changes

For the case that with current URL the welcome view is rendered due to noExperiment or server is down, this will render the trace explorer (or welcome view) after a server URL change. Without calling refresh, the welcome view stays, even if the other server has experiments. Fixes #229 Signed-off-by: Bernd Hufmann <[email protected]>
eclipse-cdt-cloud · Apr 10, 2024 · f012ced · f012ced
1 parent 86ade94
commit f012ced
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/vscode-trace-common/src/client/tsp-client-provider-impl.ts b/vscode-trace-common/src/client/tsp-client-provider-impl.ts
@@ -20,11 +20,12 @@ export class TspClientProvider implements ITspClientProvider {
 
         RestClient.addConnectionStatusListener(status => {
             // Ignore the first update that is sent when calling addConnectionStatusListener
-            if (this._initialized) {
-                this._signalHandler?.notifyConnection(status);
+            if (!this._initialized) {
+                this._initialized = true;
+                return;
             }
+            this._signalHandler?.notifyConnection(status);
         });
-        this._initialized = true;
         this._tspClient.checkHealth(); // When this is called in the remote use-case, it will block the port-forwarding service-worker.
     }
 

diff --git a/vscode-trace-extension/src/extension.ts b/vscode-trace-extension/src/extension.ts
@@ -106,6 +106,9 @@ export function activate(context: vscode.ExtensionContext): ExternalAPI {
 
                 // Signal the change to all trace panels
                 TraceViewerPanel.updateTraceServerUrl(newTspClientURL);
+
+                // Refresh so that either trace explorer or welcome page is rendered
+                vscode.commands.executeCommand('trace-explorer.refreshContext');
             }
         })
     );