Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Explorer/Welcome page not refreshed when updating the server URL (corner case) #229

Closed
bhufmann opened this issue Mar 27, 2024 · 0 comments · Fixed by #230
Closed
Assignees
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Collaborator

When updating the server URL preference to connect to a different trace server, the Trace Explorer is not rendered if the origin trace server doesn't have any traces or server is not started. Hence after the update, the welcome page stays. The refresh works fine when the original server has traces and the trace explorer is rendered. One has to press the refresh button to refresh the view.

vscode-no-refresh-at-change-url

@bhufmann bhufmann added the bug Something isn't working label Mar 27, 2024
@bhufmann bhufmann self-assigned this Mar 27, 2024
bhufmann added a commit to bhufmann/vscode-trace-extension that referenced this issue Mar 27, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes eclipse-cdt-cloud#229

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/vscode-trace-extension that referenced this issue Mar 27, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes eclipse-cdt-cloud#229

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/vscode-trace-extension that referenced this issue Mar 27, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes eclipse-cdt-cloud#229

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit that referenced this issue Mar 28, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes #229

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/vscode-trace-extension that referenced this issue Apr 10, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes eclipse-cdt-cloud#229

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit that referenced this issue Apr 10, 2024
For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes #229

Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant