Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trace explorer / welcome page refresh corner cases #230

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Fix trace explorer / welcome page refresh corner cases #230

merged 4 commits into from
Apr 10, 2024

Commits on Apr 10, 2024

  1. Add default dispose() method to AbstractTraceExplorerProvider 

    Call it from the webview dispose handler. Sub-class can add their own
implementation and call super implementation.

This avoids that the class is using the webview instance after it is
disposed.

Signed-off-by: Bernd Hufmann <[email protected]>
    @bhufmann
    bhufmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c4aa2cb View commit details
    Browse the repository at this point in the history

  2. Ignore connection status listener notification in constructor 

    The TSP client implementation notifies clients when the method
addConnectionStatusListener() is called. This can lead to incorrect
state in on client side.

Signed-off-by: Bernd Hufmann <[email protected]>
    @bhufmann
    bhufmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e4ecdb3 View commit details
    Browse the repository at this point in the history

  3. Add method to set server status in TraceServerStatusService 

    This method set the status bar and the serverUp context that is used
to decide whether the trace explorer or the welcome view should
be rendered.

This method doesn't check the backend to get status in comparison to
checkAndUpdateServerStatus. It's useful when it's known that the
server is down or up (e.g. after start notification). In this case, it
is not necessary to check the backend again.

Don't set the status in the method isTraceServerUp() because it should
not have side-effects that are not expected.

Initialize and refresh flags traceViewer.serverUp and
trace-explorer.noExperiments to ensure the correct view is rendered,
i.e. Trace Explorer or Welcome view, when certain event happen (e.g.
server started or stopped).

Fixes eclipse-cdt-cloud#227
Fixes eclipse-cdt-cloud#228

Signed-off-by: Bernd Hufmann <[email protected]>
    @bhufmann
    bhufmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b63b236 View commit details
    Browse the repository at this point in the history

  4. Refresh trace viewer after server URL preference changes 

    For the case that with current URL the welcome view is rendered due to
noExperiment or server is down, this will render the trace explorer
(or welcome view) after a server URL change. Without calling refresh,
the welcome view stays, even if the other server has experiments.

Fixes eclipse-cdt-cloud#229

Signed-off-by: Bernd Hufmann <[email protected]>
    @bhufmann
    bhufmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1f6b33a View commit details
    Browse the repository at this point in the history