[config] Adding config object to logging #1704

Peguen · 2024-08-09T14:04:20Z

Description

tbd

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-09T14:18:27Z

ecal/core/src/logging/ecal_log_impl.cpp

-      attr.broadcast = UDP::IsBroadcast();
-      attr.loopback  = true;
-      attr.sndbuf    = UDP::GetSendBufferSize();
+      eCAL::UDP::SSenderAttr attr = UDP::CreateUDPSenderAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);


warning: variable 'attr' of type 'eCAL::UDP::SSenderAttr' can be declared 'const' [misc-const-correctness]

Suggested change

eCAL::UDP::SSenderAttr attr = UDP::CreateUDPSenderAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

eCAL::UDP::SSenderAttr const attr = UDP::CreateUDPSenderAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

github-actions · 2024-08-09T14:18:27Z

ecal/core/src/logging/ecal_log_impl.cpp

-    attr.broadcast = UDP::IsBroadcast();
-    attr.loopback  = true;
-    attr.rcvbuf    = UDP::GetReceiveBufferSize();
+    eCAL::UDP::SReceiverAttr attr = UDP::CreateUDPReceiverAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);


warning: variable 'attr' of type 'eCAL::UDP::SReceiverAttr' can be declared 'const' [misc-const-correctness]

Suggested change

eCAL::UDP::SReceiverAttr attr = UDP::CreateUDPReceiverAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

eCAL::UDP::SReceiverAttr const attr = UDP::CreateUDPReceiverAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-12T10:26:32Z

ecal/core/src/logging/ecal_log_impl.cpp

+        const std::string tstring = get_time_str();
+
+        m_logfile_name = ecal_log_path + tstring + "_" + eCAL::Process::GetUnitName() + "_" + std::to_string(m_pid) + ".log";
+        m_logfile = fopen(m_logfile_name.c_str(), "w");


warning: assigning newly created 'gsl::owner<>' to non-owner 'FILE *' (aka '_IO_FILE *') [cppcoreguidelines-owning-memory]

m_logfile = fopen(m_logfile_name.c_str(), "w"); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 38. Check the log or trigger a new build to see more.

github-actions · 2024-08-13T07:23:38Z

ecal/core/src/registration/ecal_registration_timeout_provider.h

+
+        for (const auto& registration_sample : expired_samples)
+        {
+          Sample unregistration_sample = CreateUnregisterSample(registration_sample.second);


warning: variable 'unregistration_sample' of type 'Sample' can be declared 'const' [misc-const-correctness]

Suggested change

Sample unregistration_sample = CreateUnregisterSample(registration_sample.second);

Sample const unregistration_sample = CreateUnregisterSample(registration_sample.second);

github-actions · 2024-08-13T07:23:38Z

ecal/core/src/serialization/ecal_struct_sample_registration.h

    };

    // Transport layer parameters for ecal udp multicast
    struct LayerParUdpMC
    {
+      bool operator==(const LayerParUdpMC& other) const {


warning: parameter 'other' is unused [misc-unused-parameters]

Suggested change

bool operator==(const LayerParUdpMC& other) const {

bool operator==(const LayerParUdpMC& /*other*/) const {

github-actions · 2024-08-13T07:23:39Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

@@ -40,6 +40,13 @@ namespace
    return reg_sample;
  }

+  eCAL::Registration::Sample DestroyPublisher(const std::string& topic_name_, std::uint64_t topic_id_)
+  {
+    eCAL::Registration::Sample reg_sample = CreatePublisher(topic_name_, topic_id_);


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample = CreatePublisher(topic_name_, topic_id_);

eCAL::Registration::Sample reg_sample = 0 = CreatePublisher(topic_name_, topic_id_);

github-actions · 2024-08-13T07:23:39Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

@@ -52,6 +59,13 @@
    return reg_sample;
  }

+  eCAL::Registration::Sample DestroySubscriber(const std::string& topic_name_, std::uint64_t topic_id_)
+  {
+    eCAL::Registration::Sample reg_sample = CreateSubscriber(topic_name_, topic_id_);


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample = CreateSubscriber(topic_name_, topic_id_);

eCAL::Registration::Sample reg_sample = 0 = CreateSubscriber(topic_name_, topic_id_);

github-actions · 2024-08-13T07:23:39Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp

@@ -65,6 +79,13 @@
    return reg_sample;
  }

+  eCAL::Registration::Sample DestroyService(const std::string& service_name_, std::uint64_t service_id_)
+  {
+    eCAL::Registration::Sample reg_sample = CreateService(service_name_, service_id_);


warning: variable 'reg_sample' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::Registration::Sample reg_sample = CreateService(service_name_, service_id_);

eCAL::Registration::Sample reg_sample = 0 = CreateService(service_name_, service_id_);

github-actions · 2024-08-13T07:23:39Z

ecal/tests/cpp/descgate_test/src/getpublisher.cpp


  // sample should be expired
  EXPECT_EQ(0, desc_gate.GetClients().size());
 }

 TEST(core_cpp_descgate, ManyClient)
 {
-  eCAL::CDescGate desc_gate(std::chrono::milliseconds(DESCGATE_EXPIRATION_MS));
+  eCAL::CDescGate desc_gate;


warning: variable 'desc_gate' is not initialized [cppcoreguidelines-init-variables]

Suggested change

eCAL::CDescGate desc_gate;

eCAL::CDescGate desc_gate = 0;

github-actions · 2024-08-13T07:23:40Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

  // sleep
  TestingClock::increment_time(std::chrono::milliseconds(150));
 }

+TEST(core_cpp_core, ExpMap_EraseMultiple)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_core, ExpMap_EraseMultiple)

TEST(core_cpp_core /*unused*/, ExpMap_EraseMultiple /*unused*/)

github-actions · 2024-08-13T07:23:40Z

ecal/tests/cpp/registration_test/src/registration_timout_provider_test.cpp

+
+#include <chrono>
+
+#include <gtest/gtest.h>


warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h> ^

github-actions · 2024-08-13T07:23:40Z

ecal/tests/cpp/registration_test/src/registration_timout_provider_test.cpp

+#include "registration/ecal_registration_timeout_provider.h"
+#include "serialization/ecal_struct_sample_registration.h"
+
+eCAL::Registration::Sample pub_foo_process_a_unregister;


warning: variable 'pub_foo_process_a_unregister' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

eCAL::Registration::Sample pub_foo_process_a_unregister; ^

github-actions · 2024-08-13T07:23:40Z

ecal/tests/cpp/registration_test/src/registration_timout_provider_test.cpp

+#include "serialization/ecal_struct_sample_registration.h"
+
+eCAL::Registration::Sample pub_foo_process_a_unregister;
+eCAL::Registration::Sample pub_foo_process_a_register_1;


warning: variable 'pub_foo_process_a_register_1' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

eCAL::Registration::Sample pub_foo_process_a_register_1; ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-20T08:05:22Z

ecal/tests/cpp/logging_test/src/logging_test.cpp

+#include <ecal/ecal_log.h>
+#include <ecal/ecal_log_level.h>
+
+#include <gtest/gtest.h>


warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h> ^

github-actions · 2024-08-20T08:05:23Z

ecal/tests/cpp/logging_test/src/logging_test.cpp

+
+  eCAL::Logging::Log(log_message);
+
+  std::string filepath;


warning: variable 'filepath' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

Suggested change

std::string filepath;

std::string const filepath;

…alls.

…ogging test adaptions.

Peguen · 2024-08-28T11:42:00Z

Closed because of problems after merged master. Using #1724 instead.

Added config object to logging.

29f72e2

github-actions bot reviewed Aug 9, 2024

View reviewed changes

Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Aug 12, 2024

Peguen added 3 commits August 12, 2024 10:48

Clang tidy const improvements.

9f7992d

File logging - logging still enabled even if file could not be created.

9df143f

operator string() in IpAddressV4 removed.

9d0d44f

github-actions bot reviewed Aug 12, 2024

View reviewed changes

Squash merge of master 2024-08-13.

a9a0b31

github-actions bot reviewed Aug 13, 2024

View reviewed changes

Peguen added 3 commits August 13, 2024 15:56

Added logging test for filehandling.

a7c76b8

Squash merge of master 2024-08-20.

9059b39

Merge branch 'master' into feature/logging_configuration

8f1fbe1

github-actions bot reviewed Aug 20, 2024

View reviewed changes

Peguen added 14 commits August 20, 2024 13:06

Merge master.

e594bee

Merge master again.

b66a9f5

Merge remote.

dbdc5b2

Merged master 2024-08-26.

f4a344a

Added SAttr + -builder to Logging.

63056b3

Removed old logger member variables, made it indepentend of Process c…

e599b83

…alls.

Some cleanup in logging.

aa59b9f

Bugfixed ecal_log_level (unsigned char for case 255).

eb7a12c

Adapted and added some logging tests.

4a9f0ac

Adding SetUDPLogFilter function for runtime Log configuration. Some l…

976f75d

…ogging test adaptions.

Moved logToConsole in ecal_log_impl to os independent namespace.

7b93d65

Cleanup.

a1ea30a

Squash merge master 2024-08-28.

b18c79a

Moved createLogHeader in ecal_log_impl to os independent namespace.

1b4ffc2

Peguen closed this Aug 28, 2024

Peguen deleted the feature/logging_configuration branch August 28, 2024 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[config] Adding config object to logging #1704

[config] Adding config object to logging #1704

Peguen commented Aug 9, 2024

github-actions bot left a comment

github-actions bot Aug 9, 2024

github-actions bot Aug 9, 2024

github-actions bot left a comment

github-actions bot Aug 12, 2024

github-actions bot left a comment

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot left a comment

github-actions bot Aug 20, 2024

github-actions bot Aug 20, 2024

Peguen commented Aug 28, 2024

	eCAL::UDP::SSenderAttr attr = UDP::CreateUDPSenderAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);
	eCAL::UDP::SSenderAttr const attr = UDP::CreateUDPSenderAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

	eCAL::UDP::SReceiverAttr attr = UDP::CreateUDPReceiverAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);
	eCAL::UDP::SReceiverAttr const attr = UDP::CreateUDPReceiverAttr(GetConfiguration().registration, GetConfiguration().transport_layer.udp);

	Sample unregistration_sample = CreateUnregisterSample(registration_sample.second);
	Sample const unregistration_sample = CreateUnregisterSample(registration_sample.second);

	bool operator==(const LayerParUdpMC& other) const {
	bool operator==(const LayerParUdpMC& /other/) const {

	eCAL::Registration::Sample reg_sample = CreatePublisher(topic_name_, topic_id_);
	eCAL::Registration::Sample reg_sample = 0 = CreatePublisher(topic_name_, topic_id_);

	TEST(core_cpp_core, ExpMap_EraseMultiple)
	TEST(core_cpp_core /unused/, ExpMap_EraseMultiple /unused/)

[config] Adding config object to logging #1704

[config] Adding config object to logging #1704

Conversation

Peguen commented Aug 9, 2024

Description

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 9, 2024

Choose a reason for hiding this comment

github-actions bot Aug 9, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

Peguen commented Aug 28, 2024