Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Adding Attributes to logging #1724

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Aug 28, 2024

Description

Adapted logging implementation to use attributes instead of config.
Adapted logging to output warnings to console in case an enabled logging mechanism cannot be executed.
Added logging filter methods to change logging filter for each sink on runtime.
Added logging tests.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

ecal/core/include/ecal/ecal_log_level.h Show resolved Hide resolved
ecal/core/src/logging/ecal_log_impl.cpp Show resolved Hide resolved
ecal/core/src/logging/ecal_log_impl.cpp Outdated Show resolved Hide resolved
ecal/core/src/logging/ecal_log_impl.cpp Outdated Show resolved Hide resolved
ecal/tests/cpp/logging_test/src/logging_test.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

ecal/core/include/ecal/config/logging.h Show resolved Hide resolved
ecal/core/include/ecal/config/logging.h Show resolved Hide resolved
@Peguen Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Sep 2, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

ecal/core/src/logging/ecal_file_resource.cpp Outdated Show resolved Hide resolved
ecal/core/src/logging/ecal_file_resource.cpp Outdated Show resolved Hide resolved
ecal/core/src/logging/ecal_file_resource.cpp Outdated Show resolved Hide resolved
ecal/core/src/logging/ecal_file_resource.cpp Outdated Show resolved Hide resolved
ecal/core/src/logging/ecal_file_resource.cpp Outdated Show resolved Hide resolved
@Peguen Peguen marked this pull request as ready for review September 5, 2024 05:39
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Peguen Peguen merged commit e2aec45 into master Sep 27, 2024
17 of 20 checks passed
@Peguen Peguen deleted the feature/logging_configuration_0 branch September 27, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants