Add Relocation Error Codes #14893

dsouzai · 2022-04-08T15:25:10Z

Add Relocation Error codes
Update Relocation Infrastructure to return relocation error codes rather than compilation error codes
Use generic compilation error code for most relocation failures
Fix compilation failure verbose log line to print AOT load if the failed compile was an AOT load
Update storing of validation failure SCC hints to capture all validation failures
Delete unused compilation error codes

…Relocations It is possible for a few different exceptions to get thrown during relocation. This commit adds catch block for some known exceptions so that the appropriate compilation error code can be set. Signed-off-by: Irwin D'Souza <[email protected]>

runtime/compiler/runtime/RelocationRuntime.hpp

runtime/compiler/control/CompilationThread.cpp

dsouzai · 2022-04-08T15:34:26Z

@mpirvu @mstoodle could you please review? fyi @0xdaryl (since I think you were asking about this a few months ago).

mpirvu

Overall it looks good. Only a couple of nitpicks

runtime/compiler/runtime/RelocationRuntime.hpp

mpirvu · 2022-04-18T18:47:16Z

jenkins test sanity all jdk17

dsouzai · 2022-04-18T20:13:40Z

Of course there's a build break on windows...

Reading up online, it seems the error can happen because the enum's already defined elsewhere. I think it's NO_ERROR that's the problem.

I guess I'll have to rename the TR_RelocationErrorCodeType enum values...

mpirvu · 2022-04-18T20:20:28Z

f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(126): error C2059: syntax error: 'constant'
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(130): error C2143: syntax error: missing ';' before '}'
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(130): error C2059: syntax error: '}'
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(141): error C2589: 'constant': illegal token on right side of '::'
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(141): error C2062: type 'unknown-type' unexpected
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(143): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(144): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(145): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(146): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(147): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(148): error C2838: 'MISC': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(150): error C2838: 'VALIDATION': illegal qualified name in member declaration
15:26:36  f:\users\jenkins\workspace\build_jdk17_x86-64_windows_personal\openj9\runtime\compiler\runtime/RelocationRuntime.hpp(151): error C2838: 'VALIDATION': illegal qualified name in member declaration...

dsouzai · 2022-04-18T21:15:58Z

jenkins test sanity win jdk17

dsouzai · 2022-04-18T21:20:10Z

I was gonna just rename NO_ERROR but I decided to just harden the code, so I scoped the enum in a new struct called TR_RelocationError (since we can't use C++11's enum scoping). I've launched a win64 job to verify that this solves the problem; if it doesn't then I'll have to hop on a win machine and figure it out.

dsouzai · 2022-04-18T21:35:35Z

Converting to draft until I sort this all out.

Add error codes for all the various relocation errors that can occur. Signed-off-by: Irwin D'Souza <[email protected]>

The generic compilation error code will be used in places that need to determine what to do next based on the compilation failure. This is common across most relocation failures. Therefore, it is best to have a generic error code for this purpose, and use the relocation error code for RAS purposes. Signed-off-by: Irwin D'Souza <[email protected]>

Update the relocation infrastructure to return well defined relocation error codes rather than 0, -1, or a generic compilation error code. Signed-off-by: Irwin D'Souza <[email protected]>

The existing logic added a SCC hint for validation failures; this should be updated to use the relocation error codes. This not only simplifies the code, but also will now include several validation failures that were missed. Signed-off-by: Irwin D'Souza <[email protected]>

An AOT load does not use the SharedCacheVM front end. Therefore, the compilation failure line in the vlog did not print out whether the compilation was a failed AOT load. This commit fixes this by passing in the TR_MethodToBeCompiled entry, which can be used to determine whether the compile was an AOT load or not. Signed-off-by: Irwin D'Souza <[email protected]>

Signed-off-by: Irwin D'Souza <[email protected]>

dsouzai · 2022-04-19T17:25:06Z

Apparently NO_ERROR is a macro in windows, so it can't be addressed even with enum scoping. I renamed it to NO_RELO_ERROR (see force push). Verified the build succeeded on a win machine.

dsouzai · 2022-04-19T17:25:17Z

jenkins test sanity win jdk17

dsouzai · 2022-04-19T18:07:17Z

Ready for final review @mpirvu

mpirvu · 2022-04-19T20:01:35Z

jenkins compile all jdk17

mpirvu · 2022-04-19T21:10:34Z

jenkins test sanity.functional+aot all jdk17

dsouzai · 2022-04-20T14:26:00Z

AIX failure

[2022-04-20T00:28:59.944Z]  [OUT] fontmanger LIB: libfontmanager.so
[2022-04-20T00:28:59.944Z]  [ERR] Exception in thread "main" java.awt.AWTError: Can't connect to X11 window server using 'unix:0' as the value of the DISPLAY variable.

is a known issue; see #14894 (comment) and #14943.

AArch64 failure

[2022-04-19T22:51:26.287Z] Running command: "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_aarch64_linux_Personal_testList_1/openjdkbinary/j2sdk-image/bin/java" -Xshareclasses:name=test_aot -Xscmx400M -Xscmaxaot256m   -Xdump -cp "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_aarch64_linux_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/utils/utils.jar" -Xlockword:mode=minimizeFootprint VMBench.FibBench
[2022-04-19T22:51:26.287Z] Time spent starting: 2 milliseconds
[2022-04-19T22:51:28.539Z] Time spent executing: 2168 milliseconds
[2022-04-19T22:51:28.539Z] Test result: FAILED
[2022-04-19T22:51:28.539Z] Output from test:
[2022-04-19T22:51:28.539Z]  [OUT] Fibonacci: iterations = 10000
[2022-04-19T22:51:28.539Z]  [OUT] fibonacci(12) = 144
[2022-04-19T22:51:28.539Z]  [ERR] Unhandled exception
[2022-04-19T22:51:28.539Z]  [ERR] Type=Segmentation error vmState=0x00000000

is due to #13577.

mpirvu · 2022-04-21T14:15:52Z

Merging since the two tests that are failing are not due to this PR.

dsouzai added comp:jit comp:jit:aot labels Apr 8, 2022

dsouzai commented Apr 8, 2022

View reviewed changes

runtime/compiler/runtime/RelocationRuntime.hpp Outdated Show resolved Hide resolved

dsouzai commented Apr 8, 2022

View reviewed changes

runtime/compiler/control/CompilationThread.cpp Show resolved Hide resolved

dsouzai force-pushed the reloErrorCodes branch from 02d2a3b to eed5bda Compare April 8, 2022 20:55

dsouzai mentioned this pull request Apr 8, 2022

Clean up AOT infrastructure #3031

Open

8 tasks

mpirvu reviewed Apr 18, 2022

View reviewed changes

runtime/compiler/runtime/RelocationRuntime.hpp Outdated Show resolved Hide resolved

runtime/compiler/runtime/RelocationRuntime.hpp Outdated Show resolved Hide resolved

dsouzai force-pushed the reloErrorCodes branch from eed5bda to 764e07f Compare April 18, 2022 18:18

mpirvu self-assigned this Apr 18, 2022

dsouzai force-pushed the reloErrorCodes branch from 764e07f to 0f36870 Compare April 18, 2022 21:15

dsouzai marked this pull request as draft April 18, 2022 21:34

dsouzai added 7 commits April 19, 2022 13:23

Add Relocation Error Codes

62e0b92

Add error codes for all the various relocation errors that can occur. Signed-off-by: Irwin D'Souza <[email protected]>

Use relocation error codes

46ce6de

Update the relocation infrastructure to return well defined relocation error codes rather than 0, -1, or a generic compilation error code. Signed-off-by: Irwin D'Souza <[email protected]>

Print relocation error code to verbose log

2288432

Signed-off-by: Irwin D'Souza <[email protected]>

Delete unused compilation error codes

4d42c23

Signed-off-by: Irwin D'Souza <[email protected]>

dsouzai force-pushed the reloErrorCodes branch from 0f36870 to 4d42c23 Compare April 19, 2022 17:23

dsouzai marked this pull request as ready for review April 19, 2022 18:07

mpirvu approved these changes Apr 19, 2022

View reviewed changes

mpirvu merged commit 20ba075 into eclipse-openj9:master Apr 21, 2022

dsouzai deleted the reloErrorCodes branch February 3, 2023 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Relocation Error Codes #14893

Add Relocation Error Codes #14893

dsouzai commented Apr 8, 2022

dsouzai commented Apr 8, 2022

mpirvu left a comment

mpirvu commented Apr 18, 2022

dsouzai commented Apr 18, 2022

mpirvu commented Apr 18, 2022

dsouzai commented Apr 18, 2022

dsouzai commented Apr 18, 2022 •

edited

Loading

dsouzai commented Apr 18, 2022

dsouzai commented Apr 19, 2022 •

edited

Loading

dsouzai commented Apr 19, 2022

dsouzai commented Apr 19, 2022

mpirvu commented Apr 19, 2022

mpirvu commented Apr 19, 2022

dsouzai commented Apr 20, 2022 •

edited

Loading

mpirvu commented Apr 21, 2022

Add Relocation Error Codes #14893

Add Relocation Error Codes #14893

Conversation

dsouzai commented Apr 8, 2022

dsouzai commented Apr 8, 2022

mpirvu left a comment

Choose a reason for hiding this comment

mpirvu commented Apr 18, 2022

dsouzai commented Apr 18, 2022

mpirvu commented Apr 18, 2022

dsouzai commented Apr 18, 2022

dsouzai commented Apr 18, 2022 • edited Loading

dsouzai commented Apr 18, 2022

dsouzai commented Apr 19, 2022 • edited Loading

dsouzai commented Apr 19, 2022

dsouzai commented Apr 19, 2022

mpirvu commented Apr 19, 2022

mpirvu commented Apr 19, 2022

dsouzai commented Apr 20, 2022 • edited Loading

mpirvu commented Apr 21, 2022

dsouzai commented Apr 18, 2022 •

edited

Loading

dsouzai commented Apr 19, 2022 •

edited

Loading

dsouzai commented Apr 20, 2022 •

edited

Loading