Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables JNI-direct for AOT on Power #14894

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

bhavanisn
Copy link
Contributor

@bhavanisn bhavanisn commented Apr 8, 2022

Overrides the supportsDirectJNICallsForAOT call on P and thus
enabling direct JNI for AOT compiles. Related to PR #14421.

Signed-off-by: Bhavani SN [email protected]

Overrides the supportsDirectJNICallsForAOT call on P and thus
enabling direct JNI for AOT compiles. Related to PR#14421.

Signed-off-by: Bhavani SN <[email protected]>
@bhavanisn
Copy link
Contributor Author

@zl-wang @ymanton Please review the changes

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton
Copy link
Member

ymanton commented Apr 11, 2022

Jenkins test sanity.functional+aot all jdk11

Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bhavanisn
Copy link
Contributor Author

Failure on ppc64_aix is a known issue for some of AIX machines as below:
https://github.ibm.com/runtimes/infrastructure/issues/6155
As per system test, I ran the testcase through grinder on paix908 which has correct configuration but ran into space issues. https://github.ibm.com/runtimes/infrastructure/issues/6805

As the failure on mac is related to x86 and the PR has changes specific to Power, so they are not related.

@ymanton
Copy link
Member

ymanton commented Apr 19, 2022

Agreed.

@pshipton
Copy link
Member

Reverting as this caused #14941

@pshipton
Copy link
Member

Reverted by #14945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants