Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables JNI-direct for AOT on Power #14971

Merged
merged 2 commits into from
May 2, 2022

Conversation

bhavanisn
Copy link
Contributor

No description provided.

Overrides the supportsDirectJNICallsForAOT call on P and thus
enabling direct JNI for AOT compiles. Related to PR#14421.

Signed-off-by: Bhavani SN <[email protected]>
@pshipton
Copy link
Member

For history, we tried this before in #14894 but it caused #14941 so this PR should have some jdk8 testing before merge.

@bhavanisn
Copy link
Contributor Author

Yes @pshipton . I have run ppc64le tests. But not on aix_ppc64. I am currently doing that.

@bhavanisn
Copy link
Contributor Author

Aix build on jdk8:
https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/12763/
ppc64le_linux build on jdk8:
https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/12770/

@pshipton I have run these 2 tests on the branch. Do you want me to run any more tests like on jdk11 or others ?

@bhavanisn
Copy link
Contributor Author

@zl-wang @ymanton Please review the changes.

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton
Copy link
Member

ymanton commented Apr 28, 2022

Jenkins test sanity.functional plinux,aix,xlinux jdk8,jdk11

@ymanton ymanton merged commit 0bb7ce2 into eclipse-openj9:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants