Fix string literal conversion warnings in ilgen, runtime, control, ras #18470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2023
Merged
dylanjtuttle
added
the
depends:omr
dylanjtuttle
force-pushed
the
constCharStep3
branch
3 times, most recently
from
3371ff4
to
c31833d
Compare
dylanjtuttle
changed the title
dylanjtuttle
force-pushed
the
constCharStep3
branch
from
c31833d
to
b78de64
Compare
dylanjtuttle
force-pushed
the
constCharStep3
branch
2 times, most recently
from
ead270f
to
ced2613
Compare
hzongaro
reviewed
Dec 8, 2023
dylanjtuttle
force-pushed
the
constCharStep3
branch
from
ced2613
to
e18f20d
Compare
hzongaro
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Just a few minor comments and suggestions. I'm still reviewing the co-dependent pull request eclipse/omr#7187.
Fix string literal conversion warnings in runtime/compiler/ilgen Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in runtime/compiler/runtime Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
constCharStep3
branch
2 times, most recently
from
27576ef
to
edd90ba
Compare
hzongaro
reviewed
Dec 11, 2023
Fix string literal conversion warnings in runtime/compiler/control Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in kca_offsets_generator Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in omr/compiler/infra Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
constCharStep3
branch
from
edd90ba
to
473941f
Compare
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse/omr#7187 |
hzongaro
approved these changes
Dec 11, 2023
Jenkins test sanity.openjdk win jdk21 depends eclipse/omr#7187 |
|
JDK21 sanity.openjdk testing on Windows saw failures again that appear to be infrastructure-related. One testlist succeeded, while two were aborted. I think the remaining test coverage of these changes, along with additional internal testing that I ran, is sufficient to demonstrate they are safe. I will go ahead and merge the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to (char *)) in compile, runtime, control, and ras.
This PR contributes to (but does not close) #14859
This PR depends on:
and must be merged in coordination with eclipse/omr#7187