Fix string literal conversion warnings in optimizer, p #18472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjtuttle
force-pushed
the
constCharStep4
branch
from
fe0dd7a
to
4b306b6
Compare
dylanjtuttle
changed the title
hzongaro
reviewed
Dec 13, 2023
Fix string literal conversion warnings in runtime/compiler/optimizer Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in runtime/compiler/p Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
constCharStep4
branch
from
4b306b6
to
ec025b8
Compare
|
Jenkins test sanity all jdk8,jdk11,jdk17,jdk21 |
|
JDK 11 aarch64 Linux test failures appear to be due to issue #18436. I am just waiting on some internal test results before merging. |
Internal testing on various hardware and O/S combinations ran into some failures due to infrastructure issues, but there didn't seem to be any problems related to the changes from this pull request. Merging - at last! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to (char *)) in optimizer and p.
This PR contributes to (but does not close) #14859
This PR depends on: