-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent -static-libgcc and -static-libstdc++ usage on OSX #3671
Conversation
6d63b3f
to
f6c615e
Compare
Hmmm can you show an example of the compile failure? Which compiler and version was being used to compile the JIT in Issue #3669. Was this a compiler error or a compiler warning? Also the check there is supposed to be checking to make sure the option is supported... maybe that test just needs to be tweaked to test for both the libstatic-gcc and the libstatic-c++ individually and only add the ones that are supported. OS X will need to statically link the c++ library as far as I know. These links make me believe the clang supports these options: |
Breaking my local build too.
|
@charliegracie in my experience, Clang on Linux has been more compatible with gcc options compared to Xcode Clang, and does not always work the same way on both platforms. The Clang Driver patch to alias those gcc options is pretty recent. We are using Xcode 7 Clang for JDK8 OpenJ9 builds, and given that even the recently released Xcode 9 Clang is based on Clang version ~4.0 (an assumption, as Apple does not reveal that and follow an independent development of their own version), it's safe to assume it will be a while until we see Apple's version of Clang getting that support. I have tested building the JIT using the most recent release of Xcode (v 10.1), and using the linker option
Therefore, I felt it made sense to remove both these linker options for OSX. |
@nbhuiyan Do the versions of xcode in use support |
f6c615e
to
7296552
Compare
No, that is not a recognized option even in the latest version of Xcode Clang:
|
In case you are wondering whether using
|
These linker options are not supported on OSX. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
7296552
to
db0cfe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jenkins test sanity xlinux,osx jdk11 |
The osx build is hanging in the |
These linker options are not supported on OSX.
Signed-off-by: Nazim Uddin Bhuiyan [email protected]
macOS builds are currently broken due to #3594
Fixes: #3669
@babsingh @DanHeidinga @0dvictor fyi..